Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse translation strings #21308

Closed
luixxiul opened this issue Mar 4, 2022 · 5 comments
Closed

Reuse translation strings #21308

luixxiul opened this issue Mar 4, 2022 · 5 comments
Labels

Comments

@luixxiul
Copy link

luixxiul commented Mar 4, 2022

Steps to reproduce

These strings should be set to reuse the common part, in order to reduce translators' work and the high chance of translation inconsistency.

They share these strings Debug logs contain application usage data including your username, the IDs or aliases of the rooms or groups you have visited, which UI elements you last interacted with, and the usernames of other users. They do not contain messages., two of which have If you've submitted a bug via GitHub, debug logs can help us track down the problem.

Outcome

The long sentences have a high chance of translation inconsistency. They should be based on a common translation if any.

Operating system

No response

Browser information

No response

URL for webapp

develop branch

Application version

localhost

Homeserver

No response

Will you send logs?

No

@luixxiul
Copy link
Author

luixxiul commented Mar 4, 2022

one issue with splitting translations into sentences is not all languages have whitespace between sentences

The existing solution is to include the whitespace into the original strings and let translators on Weblate decide how to handle them. They can delete it to suppress the warning.

Please see https://github.com/matrix-org/matrix-react-sdk/blob/86329012f37e88ef052c84c6e59639738d7a81b0/src/components/views/dialogs/BugReportDialog.tsx#L115 for example.

@t3chguy
Copy link
Member

t3chguy commented Mar 4, 2022

https://github.com/matrix-org/matrix-react-sdk/blob/86329012f37e88ef052c84c6e59639738d7a81b0/src/components/views/dialogs/BugReportDialog.tsx#L115 is a poor example, this is bad i18n, the error should be part of the string as an interpolation due to some languages preferring different subject orders.

@luixxiul
Copy link
Author

luixxiul commented Mar 4, 2022

Sorry, I could not actually understand the reason why subject orders might matter here... The existing strings consist of two different separate sentences, and I thought they could be safely separated, unless there could be a chance that the order of those sentences should be different among languages.

@t3chguy
Copy link
Member

t3chguy commented Oct 13, 2023

We now handle the reuse piece on the Localazy side and actually split out strings further via translation keys

@t3chguy t3chguy closed this as completed Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants