-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse translation strings #21308
Comments
https://github.com/matrix-org/matrix-react-sdk/blob/86329012f37e88ef052c84c6e59639738d7a81b0/src/components/views/settings/tabs/user/HelpUserSettingsTab.tsx#L253-L258 and https://github.com/matrix-org/matrix-react-sdk/blob/86329012f37e88ef052c84c6e59639738d7a81b0/src/components/views/elements/ErrorBoundary.tsx#L95-L100 already use a single translation. https://github.com/matrix-org/matrix-react-sdk/blob/86329012f37e88ef052c84c6e59639738d7a81b0/src/components/views/dialogs/BugReportDialog.tsx#L206-L209 does not, one issue with splitting translations into sentences is not all languages have whitespace between sentences so really need to be translated whole and not piecemeal |
The existing solution is to include the whitespace into the original strings and let translators on Weblate decide how to handle them. They can delete it to suppress the warning. Please see https://github.com/matrix-org/matrix-react-sdk/blob/86329012f37e88ef052c84c6e59639738d7a81b0/src/components/views/dialogs/BugReportDialog.tsx#L115 for example. |
https://github.com/matrix-org/matrix-react-sdk/blob/86329012f37e88ef052c84c6e59639738d7a81b0/src/components/views/dialogs/BugReportDialog.tsx#L115 is a poor example, this is bad i18n, the error should be part of the string as an interpolation due to some languages preferring different subject orders. |
Sorry, I could not actually understand the reason why subject orders might matter here... The existing strings consist of two different separate sentences, and I thought they could be safely separated, unless there could be a chance that the order of those sentences should be different among languages. |
We now handle the reuse piece on the Localazy side and actually split out strings further via translation keys |
Steps to reproduce
These strings should be set to reuse the common part, in order to reduce translators' work and the high chance of translation inconsistency.
They share these strings
Debug logs contain application usage data including your username, the IDs or aliases of the rooms or groups you have visited, which UI elements you last interacted with, and the usernames of other users. They do not contain messages.
, two of which haveIf you've submitted a bug via GitHub, debug logs can help us track down the problem.
Outcome
The long sentences have a high chance of translation inconsistency. They should be based on a common translation if any.
Operating system
No response
Browser information
No response
URL for webapp
develop branch
Application version
localhost
Homeserver
No response
Will you send logs?
No
The text was updated successfully, but these errors were encountered: