Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview rageshakes before sending #3879

Closed
lampholder opened this issue May 10, 2017 · 7 comments · Fixed by matrix-org/matrix-react-sdk#3849
Closed

Preview rageshakes before sending #3879

lampholder opened this issue May 10, 2017 · 7 comments · Fixed by matrix-org/matrix-react-sdk#3849
Assignees
Labels
A-Feedback-Reporting Reporting process for bugs, debug logs (rageshakes), suggestions P1 T-Enhancement

Comments

@lampholder
Copy link
Member

I thought I saw this filed already but might have hallucinated it (or confused it with the rageshaked issue).

Users would like to be able to preview rageshake logs before uploading. Seems sensible.

@richvdh
Copy link
Member

richvdh commented May 10, 2017

sensible, but non-trivial.

It's not a regression - users have never been able to preview the logs sent from riot-web.

@lampholder
Copy link
Member Author

Cool, in which case it's not a bug, either :P

@ara4n
Copy link
Member

ara4n commented May 14, 2017

hang on - can we not just provide a link to download the log archive that'll be sent to the server before sending it? i assume we have it in RAM somewhere, so we should just be able to use https://github.com/eligrey/FileSaver.js/ or whatever trick the e2e attachment downloader already uses?

@richvdh
Copy link
Member

richvdh commented May 14, 2017 via email

@ara4n
Copy link
Member

ara4n commented May 14, 2017

what about just providing it in precisely the format we make it when sending to the server anyway? anyone smart enough to dissect their logs is smart enough to ungzip something...

@richvdh
Copy link
Member

richvdh commented May 15, 2017 via email

@uhoreg
Copy link
Member

uhoreg commented May 18, 2017

related to #3304 (and the proposed solution so far would probably fix that issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Feedback-Reporting Reporting process for bugs, debug logs (rageshakes), suggestions P1 T-Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants