-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preview rageshakes before sending #3879
Comments
sensible, but non-trivial. It's not a regression - users have never been able to preview the logs sent from riot-web. |
Cool, in which case it's not a bug, either :P |
hang on - can we not just provide a link to download the log archive that'll be sent to the server before sending it? i assume we have it in RAM somewhere, so we should just be able to use https://github.com/eligrey/FileSaver.js/ or whatever trick the e2e attachment downloader already uses? |
Hrm, I suppose we can, actually. We have it in indexeddb, and we'd have to build it into a zip file or something for the user to download, but we could do that.
…On 15 May 2017 00:05:27 BST, Matthew Hodgson ***@***.***> wrote:
hang on - can we not just provide a link to download the log archive
that'll be sent to the server before sending it? i assume we have it
in RAM somewhere, so we should just be able to use
https://github.com/eligrey/FileSaver.js/ or whatever trick the e2e
attachment downloader already uses?
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#3879 (comment)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
what about just providing it in precisely the format we make it when sending to the server anyway? anyone smart enough to dissect their logs is smart enough to ungzip something... |
It's a bunch of separate gzipped files in the upload. We could give you a download link for each file.
…On 15 May 2017 00:21:09 BST, Matthew Hodgson ***@***.***> wrote:
what about just providing it in precisely the format we make it when
sending to the server anyway? anyone smart enough to dissect their logs
is smart enough to ungzip something...
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#3879 (comment)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
related to #3304 (and the proposed solution so far would probably fix that issue) |
I thought I saw this filed already but might have hallucinated it (or confused it with the rageshaked issue).
Users would like to be able to preview rageshake logs before uploading. Seems sensible.
The text was updated successfully, but these errors were encountered: