-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace external images with alt text instead of completely stripping them out #4044
Comments
Instead of the alt text, could it just drop the src in place? Otherwise this would be a bit weird: |
Plot twist: dog.png is actually a picture of a squid. 😉 |
imho at least docs should mention this behaviour, I personally found it very strange, that images just disappear out of markdown texts, and even used a mattermost instance just to double check if my syntax was at fault. Also I would love to disable it, personally. I guess this has to do with encryption? |
@g4borg primarily privacy and availability, |
@lukebarnard1 This issue is still valid. It also occurs when you disable displaying images within your client. In this case, the sanitizer also strips off all tags and leaves a bare It is also starting to feel more important as sending custom reactji pastes in an |
I understand the previous comment to be referring to matrix-org/matrix-spec-proposals#2545 which is implemented by FluffyChat, Nheko and Cinny. |
The message shown below includes an <IMG> element with an alt attribute pointing to a non-MXC image.
Since it is a non-MXC image, Riot strips out the image, but it would be nice to replace it with the alt text instead, since that is provided.
The text was updated successfully, but these errors were encountered: