Reset cross-signing before backup when resetting both #28402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Jest test looks like just a flaky test. No idea why SonarCloud isn't reporting anything. And earlier version of this PR had 70% test coverage. I've since added another test, but I don't know if that's enough for SonarCloud until SonarCloud returns its result. I think that this PR is otherwise ready for review. |
t3chguy
approved these changes
Nov 8, 2024
|
If a jest test fails/flakes then Sonar won't run as it won't have a complete junit report to work from |
| * cross-signing to be reset (so that the new backup can be | ||
| * signed by the new cross-signing key). So we reset secret | ||
| * storage first, then cross-signing, then key backup. | ||
| */ | ||
| logger.log("Forcing secret storage reset"); | ||
| await crypto.bootstrapSecretStorage({ |
There was a problem hiding this comment.
Why not add the resetCrossSigning as an option to bootstrapSecretStorage?
There was a problem hiding this comment.
Mainly just to avoid making such an invasive change.
BillCarsonFr
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that the backup gets signed by the new cross-signing key
Checklist
public/exportedsymbols have accurate TSDoc documentation.