Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After opening multiple notifications, going back from room view does not navigate to rooms list view #3098

Closed
nathanael-h opened this issue Jun 26, 2024 · 7 comments · Fixed by #3984
Labels
A-Navigation O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Needs-Product Issue needs input from Product team

Comments

@nathanael-h
Copy link

nathanael-h commented Jun 26, 2024

Steps to reproduce

  1. Ensure you received multiple notifications for different rooms
  2. Open notification for room1
  3. Room1 is opened
  4. Open notification for room2
  5. Room2 is opened
  6. Open notification for room3
  7. Room3 is opened
  8. Touch back arrow on top left
  9. App navigate from room3 to room2
  10. Touch back arrow
  11. App navigate from room2 to room1
  12. Touch back arrow
  13. App navigate from room1 to room list view

Outcome

What did you expect?

I expected that the back arrow navigate directly to the room list view

What happened instead?

It seems that opening a room notification push the room view on the navigation stack and that the back arrow simply pop the latest view from the navigation stack
I think that opening a room notification should clear the navigation stack before pushing a new view on it.

Your phone model

Fairphone 3+

Operating system version

Android 13, /e/OS 2.1

Application version and app store

Element X Android 0.4.14

Homeserver

matrix.isidorus.fr / yunohost / synapse version 1.109.0 / sliding sync v0.99.18

Will you send logs?

No

Are you willing to provide a PR?

No

@nathanael-h nathanael-h added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Jun 26, 2024
@bmarty
Copy link
Member

bmarty commented Jun 26, 2024

Thanks. There are pros and cons to implement this change. Let's ask for a product decision.

@bmarty bmarty added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely X-Needs-Product Issue needs input from Product team A-Navigation labels Jun 26, 2024
@frebib
Copy link
Contributor

frebib commented Jun 26, 2024

In the very least, if a room is in the backstack more than once, I would expect that the most recent copy of that room would remain open (especially now that we have draft support) but the older duplicates would be removed, otherwise you could end up revisiting the same room many many times trying to get out of the backstack from a ton of notifications

@nathanael-h
Copy link
Author

Hello, I kindly share with you that this annoying issue drove me to test another Matrix client and finally use it daily (Fluffychat). Don't get me wrong, I share with you this end-user feedback so that you and the product and UX team can use it. I do not want to pressure.

To explain more what is annoying: after a few hours away from phone (and also from any other matrix client), I might have messages in multiple matrix rooms (6 for example), with many new notifications. I open notification one after another. And at the end when I want to get back to the rooms list, I need to hit back arrow as many times as I got notifications (at least 6, sometimes more).

@atomdmac
Copy link

@bmarty What are the cons to implementing this change? What the use cases where the current behavior is desirable?

@titulebolide
Copy link

I really do agree with @nathanael-h. After a long time opening successively many notifications, this is quite surprising having to go back several time.
I think this would also be consistent with the UX of other messaging app.

@0verEngineer
Copy link

No other messaging app does this, i don't get what the cons are in fixing this. This is simply broken UX.

@Destinyg133
Copy link

I dont understand what would cons be of fixing this. Id also agree its broken UX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Navigation O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Needs-Product Issue needs input from Product team
Projects
None yet
7 participants