Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navigation : clear backstack when opening room from outer node #3984

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Dec 2, 2024

Content

Take over #3968

Reset the navigation to the room list level. This is the behaviour in most IM apps, and it seems more natural (tested this on WhatsApp, Telegram and also EXI).
The room is always added to the backstack, even if already stashed or active.

Motivation and context

Fixes #3098

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@ganfra ganfra added the PR-Bugfix For bug fix label Dec 2, 2024
@ganfra ganfra marked this pull request as ready for review December 2, 2024 20:49
@ganfra ganfra requested a review from a team as a code owner December 2, 2024 20:49
@ganfra ganfra requested review from bmarty and removed request for a team December 2, 2024 20:49
Copy link
Contributor

github-actions bot commented Dec 2, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/djwH5m

Copy link

sonarcloud bot commented Dec 2, 2024

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 83.05%. Comparing base (181cf56) to head (5ea8d57).
Report is 26 commits behind head on develop.

Files with missing lines Patch % Lines
...tlin/io/element/android/appnav/LoggedInFlowNode.kt 0.00% 18 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3984      +/-   ##
===========================================
+ Coverage    83.03%   83.05%   +0.02%     
===========================================
  Files         1796     1806      +10     
  Lines        45600    45656      +56     
  Branches      5375     5380       +5     
===========================================
+ Hits         37864    37921      +57     
+ Misses        5855     5848       -7     
- Partials      1881     1887       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK! Thanks.

@ganfra ganfra enabled auto-merge December 3, 2024 11:08
@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 3, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 3, 2024
@ganfra ganfra merged commit cab81a0 into develop Dec 3, 2024
33 of 34 checks passed
@ganfra ganfra deleted the feature/fga/navigation_from_notification_2 branch December 3, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After opening multiple notifications, going back from room view does not navigate to rooms list view
2 participants