Ignore punctuation characters at the end of detected links

- fixes permalink handling when that's the case - prevents deep linking loops between nightly and the main app
element-hq · Jun 19, 2024 · bbf5b91 · bbf5b91
1 parent f16b9aa
commit bbf5b91
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 3 deletions.
diff --git a/ElementX/Sources/Other/HTMLParsing/AttributedStringBuilder.swift b/ElementX/Sources/Other/HTMLParsing/AttributedStringBuilder.swift
@@ -191,6 +191,13 @@ struct AttributedStringBuilder: AttributedStringBuilderProtocol {
                 link.insert(contentsOf: "https://", at: link.startIndex)
             }
 
+            // Don't include punctuation characters at the end of links
+            // e.g `https://element.io/blog:` <- which is a valid link but the wrong place
+            while !link.isEmpty,
+                  link.rangeOfCharacter(from: .punctuationCharacters, options: .backwards)?.upperBound == link.endIndex {
+                link = String(link.dropLast())
+            }
+
             return TextParsingMatch(type: .link(urlString: link), range: match.range)
         })
 

diff --git a/UnitTests/Sources/AttributedStringBuilderTests.swift b/UnitTests/Sources/AttributedStringBuilderTests.swift
@@ -110,6 +110,23 @@ class AttributedStringBuilderTests: XCTestCase {
         XCTAssertEqual(link?.host, "www.matrix.org")
     }
 
+    func testPunctuationAtTheEndOfPlainStringLinks() {
+        let plainString = "This text contains a https://www.matrix.org:;., link."
+
+        guard let attributedString = attributedStringBuilder.fromPlain(plainString) else {
+            XCTFail("Could not build the attributed string")
+            return
+        }
+
+        XCTAssertEqual(String(attributedString.characters), plainString)
+
+        XCTAssertEqual(attributedString.runs.count, 3)
+
+        let link = attributedString.runs.first(where: { $0.link != nil })?.link
+
+        XCTAssertEqual(link?.host, "www.matrix.org")
+    }
+
     func testLinkDefaultScheme() {
         let plainString = "This text contains a matrix.org link."
 
@@ -177,9 +194,13 @@ class AttributedStringBuilderTests: XCTestCase {
     }
 
     func testLinkWithFragment() {
-        let string = "https://example.com/#/"
-        checkLinkIn(attributedString: attributedStringBuilder.fromHTML(string), expectedLink: string, expectedRuns: 1)
-        checkLinkIn(attributedString: attributedStringBuilder.fromPlain(string), expectedLink: string, expectedRuns: 1)
+        var string = "https://example.com/#/"
+        checkLinkIn(attributedString: attributedStringBuilder.fromHTML(string), expectedLink: "https://example.com", expectedRuns: 1)
+        checkLinkIn(attributedString: attributedStringBuilder.fromPlain(string), expectedLink: "https://example.com", expectedRuns: 1)
+
+        string = "https://example.com/#/some_fragment/"
+        checkLinkIn(attributedString: attributedStringBuilder.fromHTML(string), expectedLink: "https://example.com/#/some_fragment", expectedRuns: 1)
+        checkLinkIn(attributedString: attributedStringBuilder.fromPlain(string), expectedLink: "https://example.com/#/some_fragment", expectedRuns: 1)
     }
 
     func testPermalink() {