Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Local Media Admin APIs unnecessarily requires specifying local server_name #9284

Open
matrixbot opened this issue Dec 18, 2023 · 0 comments

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 18, 2023

This issue has been migrated from #9284.


The Delete Local Media Admin APIs require you to include the server name of your local homeserver in the path parameters. If you provide something other than the correct server name, the request will be rejected.

There doesn't seem to be much point in that, especially when the remote media deletion admin APIs don't allow specifying a server name.

It's also confusing as people see POST /_synapse/admin/v1/media/<server_name>/delete?before_ts=<before_ts> and assume it works for any given server name, as seen here: matrix-org/synapse#3479 (comment)

I believe this may have come from existing Media Admin APIs, such as Quarantine Media, which required a server_name path parameter, where any server name could be specified.

We should rework this to remove the requirement of specifying the local server name - which is already known by the homeserver, and possibly make it a bit more obvious from the path that this is for local media only.

@matrixbot matrixbot changed the title Dummy issue Delete Local Media Admin APIs unnecessarily requires specifying local server_name Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant