Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange headerbar items #803

Merged
merged 1 commit into from
Nov 11, 2023
Merged

Rearrange headerbar items #803

merged 1 commit into from
Nov 11, 2023

Conversation

danirabbit
Copy link
Member

Re-arranges some header items so that they are more closely associated with the pane they directly act on:

  • The calendar settings and export buttons move to the calendar pane since the export button acts on the default calendar, not the currently visible agenda items, and the settings popover affects which calendars are shown in the calendar view
  • The create new event button is now in the agenda pane since the event will be created for the selected day as labeled in this pane
  • The agenda pane's label moves up into the header to make more room for events

BEFORE

Screenshot from 2023-11-10 11 15 42

AFTER

Screenshot from 2023-11-10 11 21 26

@danirabbit danirabbit requested a review from a team November 10, 2023 19:22
Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Both the code and the new design!

@zeebok zeebok merged commit d941568 into master Nov 11, 2023
3 checks passed
@zeebok zeebok deleted the danirabbit/header-rearrange branch November 11, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants