Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix target model initialisation #486

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Conversation

uremes
Copy link
Contributor

@uremes uremes commented Jul 4, 2024

Summary:

This update postpones surrogate model initialisation in BOLFI and BOLFIRE until n_initial_evidence data points are available and initialises the model based on all this data. Fixes #425

In the current implementation, the model is initialised based on batch_size data points. This is a problem when batch_size is small because the priors applied on the default kernel are also determined based on the initialisation data and become sensitive to the random seed. For example, see what happens in BOLFI tutorial notebook with seed=310522 vs seed=1 or BOLFIRE tutorial notebook with seed=100123 vs seed=10.

Please make sure

  • You have read contribution guidelines
  • You have updated CHANGELOG.rst
  • You have listed the copyright holder for the work you are submitting (see next section)

If your contribution adds, removes or somehow changes the functional behavior of the package, please check that

  • You have included or updated all the relevant documentation, including docstrings
  • You have added appropriate functional and unit tests to ensure the new features behave as expected
  • You have run make lint, make docs and make test

and the proposed changes pass all unit tests (check step 6 of CONTRIBUTING.rst for details)

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@uremes uremes requested a review from hpesonen July 4, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random variation in default kernel parameters
1 participant