[fix] Recrear contenedores con docker-compose #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker compose has a problem with running containers names. If container names are the same they need to be recreated or they'll clash. This also removes trailing whitespace.
This will make the github jobs run faster by caching the image layers. Current layers shouldn't be that big so this is a small optimization. It's unknown how much free disk space it's using to cache the layers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuación de #14, #13, #12, #11...
El archivo de configuración de docker tiene un nombre para el contenedor de webpack. Al intentar levantar un contenedor con la nueva imagen, hay una colisión entre el viejo contenedor y el nuevo contenedor porque usan el mismo nombre. Con la opción
--force-recreatedocker-compose no debería tener problemas.También he agregado una pequeña optimización a la build inicial. Lo que tarda mucho en la build es descargar la imagen y extraerla. Será mejor una vez que tenga un nuevo rPI.