Recognize ? char syntax #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a syntax-propertize function that will ferret out non-constituent ? characters and apply the generic string delimiter syntax text property to it and the character it escapes. (This handles ?\# sequences too.) Fixes elixir-editors#26.
Since we're using a syntax property function, we can attempt to be smarter about parser state. I'd like to extend this to sigil expressions, also (which I suspect might be a possible way to fix elixir-editors#23).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the same issue as #26, except without the indent breakage.
The change introduces a syntax propertization hook, which will rewrite the syntax properties for any free-standing
?and the character it escapes.