Gray out ignored variables #296
Conversation
| @@ -426,6 +426,33 @@ end | |||
| " | |||
| (should (eq (elixir-test-face-at 33) 'font-lock-string-face)))) | |||
|
|
|||
| (ert-deftest elixir-mode-syntax-table/gray-out-ignored-var () | |||
There was a problem hiding this comment.
I have little experience writing these kind of tests.
Is this acceptable ?
|
I suppose you should use own face instead of |
|
Great job @rranelli, I've been wishing for this for a while now 🎉 😃 |
|
@syohex I think you're right, "gray out" is not the best way to describe it. I used the I see no problem creating a new face though. |
rranelli
force-pushed
the
gray-out-ignored-vars
branch
from
88b391d to
e127a0e
Compare
rranelli
force-pushed
the
gray-out-ignored-vars
branch
from
e127a0e to
5ec730d
Compare
This commit grays out variables whose name start with `_`. These variables are meant to be ignored in the program. The fontification of the single underscore matcher (`_`) and pseudo-variables like `__MODULE__` & company where not modified. See elixir-editors#292. Fixes elixir-editors#292
|
Looks good 👍 |
|
@rranelli Great! Thank you :-D |
* Do not advertise workspaceFolder support In elixir-lsp/elixir-ls#295 the user received a warning: > Received unmatched notification: %{"jsonrpc" => "2.0", "method" => "workspace/didChangeWorkspaceFolders" This occurs because the server advertises that it supports workspace folders: https://microsoft.github.io/language-server-protocol/specification#workspace_workspaceFolders This was introduced in elixir-lsp/elixir-ls#35 which was actually about didChangeWatchedFiles and not workspace folders. Fixes elixir-editors#296 * Update changelog
This commit grays out variables whose name start with
_. Thesevariables are meant to be ignored in the program. The fontification of
the single underscore matcher (
_) and pseudo-variables like__MODULE__& company where not modified.See #292.
Before this commit:
After this commit:
Fixes #292