Fontify ~D() sigil #373
Merged
Fontify ~D() sigil #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
couldn't get the tests to run on my machine ~ I will fix them later today |
syohex
reviewed
Sep 19, 2016
| @@ -167,7 +167,7 @@ | |||
| (or "_" "__MODULE__" "__DIR__" "__ENV__" "__CALLER__" | |||
| "__block__" "__aliases__") | |||
| symbol-end)) | |||
| (sigils . ,(rx "~" (or "B" "C" "R" "S" "b" "c" "r" "s" "w"))))) | |||
| (sigils . ,(rx "~" (or "D" "B" "C" "R" "S" "b" "c" "r" "s" "w"))))) | |||
There was a problem hiding this comment.
Should "D" be after "C" ? Because original order is ascii(alphabetical) order.
There was a problem hiding this comment.
Alright ~ fair point.
Done !
tonini
requested changes
Sep 20, 2016
This commit adds fontification support to the new date sigil added in Elixir 1.3 Signed-off-by: Milhouse <renanranelli@gmail.com>
|
Fixed @tonini :) I got the wrong position in the test ~ |
tonini
approved these changes
Sep 21, 2016
|
Thanks @rranelli 👍 |
|
always happy to help <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds fontification support to the new date sigil added in Elixir 1.3
Signed-off-by: Milhouse renanranelli@gmail.com