Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit faces from appropriate builtin ones #441

Merged
merged 1 commit into from
Aug 31, 2019
Merged

Inherit faces from appropriate builtin ones #441

merged 1 commit into from
Aug 31, 2019

Conversation

sirikid
Copy link
Contributor

@sirikid sirikid commented Aug 14, 2019

Subj

@Trevoke
Copy link
Contributor

Trevoke commented Aug 30, 2019

@sirikid Thanks for the pull request! Could you please add a screenshot of the resulting change?

@sirikid
Copy link
Contributor Author

sirikid commented Aug 31, 2019

Top with new faces, bottom with defaults. (Themes are kaolin-dark, challenger-deep, leuven and eink.)
image

@Trevoke
Copy link
Contributor

Trevoke commented Aug 31, 2019

Seems like a much better fit for the themes! Thanks for the contribution :)

@Trevoke Trevoke merged commit f101c67 into elixir-editors:master Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants