-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert admonition blockquotes to sections for screen reader users #1938
Merged
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
2813258
Convert admonition blockquotes to divs
voughtdq dad588b
Fix styles, format code
voughtdq 498b96c
Update admonition styles for epub
voughtdq 7174cb3
Make sure to test for admonition class
voughtdq 263c082
Use section tags for admonitions
voughtdq 7f61e1b
Update print and tabset styles
voughtdq 30dc41b
Simplify section.admonition to .admonition
voughtdq c586c8e
Simplify admonition styles further
voughtdq b907d27
Replace .admonition with section.admonition
voughtdq 8f4b5d8
Simplify remaining styles
voughtdq 3888ab0
Add missed selector
voughtdq 89068be
Merge branch 'elixir-lang:main' into accessible-admonitions
voughtdq 0d9ad85
Identifiy admonition headings with a class
voughtdq bf032c3
Use List.key*/*, re-organize tests
voughtdq 5fd1ca8
Update JS, fix bug caused by missing a CSS selector
voughtdq 7a5ad41
Minor tweak: add " " as second arg to split/2
voughtdq File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to keep everything self-contained instead of adding helper functions, so that's why this is a little messy. The "coercion" to
""
is there since the call toEnum.join/2
will return an empty string for an empty list.