Admin panel #6
Merged
Admin panel #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szewczukk
force-pushed
the
admin-panel-2
branch
from
6adccc7 to
2664d16
Compare
sgfn
reviewed
Mar 3, 2025
Member
sgfn
left a comment
sgfn
left a comment
There was a problem hiding this comment.
- Could we try to have a layout like this?
-----------------------------------
|Title | |
|------------------------------|Save|
|description | |
-----------------------------------
... rest of page
- Nearly all of our UI is grouped into "blocks" with a blue border. Let's wrap this "title-description-save" addition in one as well, so that it looks like the single logical group it is
sgfn
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, check -> elixir-webrtc/live_ex_webrtc#9