Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New payment method logo error #226

Closed
rtomagnini opened this issue Mar 13, 2024 · 4 comments · Fixed by #227
Closed

New payment method logo error #226

rtomagnini opened this issue Mar 13, 2024 · 4 comments · Fixed by #227
Assignees
Labels
bug Something isn't working Completed Feature is implemented and merged

Comments

@rtomagnini
Copy link

When I try to add a new payment method and select a logo through the search or by adding it manually, the image doesn't appear. It shows as a broken link.

@rtomagnini
Copy link
Author

IMG_3083

@ellite
Copy link
Owner

ellite commented Mar 13, 2024

Hi, can you right click on the image and click on inspect element and paste here the url that is failing?

Thanks.

Repository owner deleted a comment from rtomagnini Mar 13, 2024
@ellite
Copy link
Owner

ellite commented Mar 13, 2024

I see the issue.
if you replace /icons by /logos the image is there.
I'm using the id of the payment method to change the folder where to pick the image for.
The payment methods already on the system have the logos on /icons and the custom payment methods on /logos
Seems that the ID is not incrementing but reusing IDs of deleted payment methods.
I will have to find a solution for it. I'll add it to my list.

Thank you for the report.

@ellite ellite self-assigned this Mar 13, 2024
@ellite ellite added the bug Something isn't working label Mar 13, 2024
@ellite ellite linked a pull request Mar 13, 2024 that will close this issue
@ellite
Copy link
Owner

ellite commented Mar 13, 2024

Released a new version (1.16.2). Hopefully it fixes it.
You need to remove the custom payment methods and add them again.

Regards.

@ellite ellite added the Completed Feature is implemented and merged label Mar 17, 2024
@ellite ellite closed this as completed Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Completed Feature is implemented and merged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants