Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing authentication check #133

Merged
merged 2 commits into from
Feb 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions SECURITY.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
# Security Policy

## Reporting a Vulnerability

If you discover any security vulnerabilities in this project, please report them to the developer by emailing [wallos@henrique.pt](mailto:wallos@henrique.pt). I appreciate your help in keeping the project secure.

## Supported Versions

This project is currently supported with security updates for the following versions:

| Version | Supported |
| ------- | ------------------ |
| latest | :white_check_mark: |
| main | :white_check_mark: |
| 1.x.x | :x: |

## Security Measures

I take security seriously and am working on ways to implement security measures to protect the project.

## Reporting a Security Concern

If you have any security concerns or questions regarding the security of this project, please contact the developer at [wallos@henrique.pt](mailto:wallos@henrique.pt).

## Responsible Disclosure

I kindly request that you follow responsible disclosure practices and give me reasonable time to address any reported vulnerabilities before making them public.

7 changes: 6 additions & 1 deletion endpoints/payments/payment.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,12 @@

$paymentId = $_GET['paymentId'];

$inUse = $db->querySingle('SELECT COUNT(*) as count FROM subscriptions WHERE payment_method_id=' . $paymentId) === 1;
$stmt = $db->prepare('SELECT COUNT(*) as count FROM subscriptions WHERE payment_method_id=:paymentId');
$stmt->bindValue(':paymentId', $paymentId, SQLITE3_INTEGER);
$result = $stmt->execute();
$row = $result->fetchArray();
$inUse = $row['count'] === 1;

if ($inUse) {
die(json_encode([
"success" => false,
Expand Down
7 changes: 7 additions & 0 deletions endpoints/subscriptions/export.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@

session_start();

if (!isset($_SESSION['loggedin']) || $_SESSION['loggedin'] !== true) {
die(json_encode([
"success" => false,
"message" => translate('session_expired', $i18n)
]));
}

require_once '../../includes/getdbkeys.php';

$query = "SELECT * FROM subscriptions";
Expand Down