Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #158 insertstyle node modules export docs #164

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

elycruz
Copy link
Owner

@elycruz elycruz commented Sep 25, 2024

Cleans up docs related to using the insert feature.

Related to #157 and #158 .

- Simplified the usage notice
  and added link to 'package.json.files'
  docs.
- Simplified the usage notice
  and added link to 'package.json.files'
  docs.
@elycruz elycruz added enhancement docs Documentation issue. labels Sep 25, 2024
@elycruz elycruz self-assigned this Sep 25, 2024
@marcalexiei
Copy link
Contributor

I opened #163 10 minutes ago.
When you have time consider to take a look.

It could solve the problem in a more "graceful" way 😄

@elycruz
Copy link
Owner Author

elycruz commented Sep 25, 2024

:-D, yeah I saw - I figured since I had updated the snippet I would added it for correctness/have it in the git history.

Started reviewing your PR though if we could get the required update on it's (apart from the prettier stuff) that would be better (as I don't get too much time for reviewing the PRs);

Let's try to go for PRs/branches that build off each other (if necessary) - will allow for PR reviews to be completed faster.

@marcalexiei
Copy link
Contributor

Started reviewing your PR though if we could get the required update on it's (apart from the prettier stuff) that would be better

Prettier PR changes are nearly all related to code formatting, so they should't take long.
In addition I highlighted some unrelated changes using review comments to speed up the review 🙂.


if we could get the required update on it's (apart from the prettier stuff) that would be better

IMHO having a formatter and a linter (coming 🔜) ensure that the code is more readable and subject to errors,
so I consider prettier PR more important 😃


(I don't get too much time for reviewing the PRs)

If you wish you can add me as collaborator with the triage permission:
"Can read and clone this repository. Can also manage issues and pull requests"

I can't edit or write any information related to the repository code and settings.
More info can be found here

But with that permission at least I can at have CI checks running and avoid one review cycle just to fix some CI error 😅.

If you do not want to add me, no problem, I understand 😉.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation issue. enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants