Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#81 - Changed 'rollup-pluginutils' back to '@rollup/pluginutils' plugin and reverted previous code change #82

Merged
merged 3 commits into from
Aug 25, 2021

Conversation

elycruz
Copy link
Owner

@elycruz elycruz commented Aug 25, 2021

Fixes #81 :

Changes:

  • Reverted rollup-pluginutils version back to recently upgraded @rollup/pluginutils version, minus one major version from latest version - The version is set to one major behind to ensure backwards compatibility with existing projects.
    We also upgraded to this version, of @rollup/pluginutils, to allow users, who have started to use rollup-plugin-sass@1.2.5, to continue supplying RegExp | string | string[] for include and exclude properties (rollup-pluginutils doesn't accept RegExp for these props).
  • Updated plugin's source to ensure that include and exclude always have a default when their incoming values are directly set to undefined - previous update had removed these default, since they were set in options merge call, however merging in undefined prop. values weren't taken into account in that update - this update fixes that change.
  • Downgraded typescript version down to previous major version to ensure we don't output typescript type files that are incompatible with older versions of typescript - it's a good practice to not use the latest typescript version, currently, since some older typescript versions have issues with some of the syntaxes used in later versions of typescript (see: Managing code compatibility in a TypeScript ecosystem with multiple compiler versions microsoft/TypeScript#25778 et al.).

…sures we don't break applications that were already using new, allowed, formats for 'include' and 'exclude' props (@rollup/pluginutils allows 'RegExp' as well as 'string | string[]' for these props). Updated plugin source to ensure we have defaults for 'include' and 'exclude' options, even when merged, incoming options contain 'undefined' values for these props - feature was previously removed, it is now re-added in this commit.
@elycruz elycruz changed the base branch from master to dev August 25, 2021 01:05
@elycruz elycruz merged commit 8edd083 into dev Aug 25, 2021
@elycruz elycruz deleted the bugfix/#81-rollup-pluginutils_update branch August 25, 2021 01:10
@elycruz elycruz mentioned this pull request Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in version 1.2.5
1 participant