diff --git a/canvas_modules/common-canvas/src/common-properties/components/editor-form/editor-form.jsx b/canvas_modules/common-canvas/src/common-properties/components/editor-form/editor-form.jsx index b823533d50..e8b65fa711 100644 --- a/canvas_modules/common-canvas/src/common-properties/components/editor-form/editor-form.jsx +++ b/canvas_modules/common-canvas/src/common-properties/components/editor-form/editor-form.jsx @@ -270,7 +270,6 @@ class EditorForm extends React.Component { return ( {tabLists} diff --git a/canvas_modules/common-canvas/src/common-properties/components/title-editor/title-editor.jsx b/canvas_modules/common-canvas/src/common-properties/components/title-editor/title-editor.jsx index 10c96ee64b..86cb26b0a6 100644 --- a/canvas_modules/common-canvas/src/common-properties/components/title-editor/title-editor.jsx +++ b/canvas_modules/common-canvas/src/common-properties/components/title-editor/title-editor.jsx @@ -20,7 +20,7 @@ import { connect } from "react-redux"; import { setTitle } from "./../../actions"; import Isvg from "react-inlinesvg"; import { get } from "lodash"; -import { TextInput, Button } from "@carbon/react"; +import { TextInput, Button, Layer } from "@carbon/react"; import { MESSAGE_KEYS, CONDITION_MESSAGE_TYPE } from "./../../constants/constants"; import * as PropertyUtils from "./../../util/property-utils"; import classNames from "classnames"; @@ -181,25 +181,26 @@ class TitleEditor extends Component { } )} > - this._handleKeyPress(e)} - readOnly={this.props.labelEditable === false} // shows a non editable icon - labelText={this.labelText} - hideLabel - size="sm" - onFocus={this.textInputOnFocus} - onBlur={this.textInputOnBlur} - light={this.props.controller.getLight()} - invalid={titleWithErrror} - invalidText={get(this.state.titleValidation, "message")} - warn={titleWithWarning} - warnText={get(this.state.titleValidation, "message")} - {... this.state.focused && { className: "properties-title-editor-focused" }} - /> + + this._handleKeyPress(e)} + readOnly={this.props.labelEditable === false} // shows a non editable icon + labelText={this.labelText} + hideLabel + size="sm" + onFocus={this.textInputOnFocus} + onBlur={this.textInputOnBlur} + invalid={titleWithErrror} + invalidText={get(this.state.titleValidation, "message")} + warn={titleWithWarning} + warnText={get(this.state.titleValidation, "message")} + {... this.state.focused && { className: "properties-title-editor-focused" }} + /> + {titleValidationTypes.includes(get(this.state.titleValidation, "type")) ? null : propertiesTitleEdit} {!this.headingEnabled && !titleValidationTypes.includes(get(this.state.titleValidation, "type")) ? helpButton : null} diff --git a/canvas_modules/common-canvas/src/common-properties/components/title-editor/title-editor.scss b/canvas_modules/common-canvas/src/common-properties/components/title-editor/title-editor.scss index 36ce95a816..df62a552da 100644 --- a/canvas_modules/common-canvas/src/common-properties/components/title-editor/title-editor.scss +++ b/canvas_modules/common-canvas/src/common-properties/components/title-editor/title-editor.scss @@ -53,10 +53,11 @@ &.properties-title-editor-with-help { width: calc(100% - #{$spacing-07} - #{$spacing-03}); // subtract the size of the help button and 8px to align with Close icon when applyOnBlur is set } - .cds--form-item.cds--text-input-wrapper { + .properties-title-editor-layer { // allow edit icon to be at the end of text input width: 100%; - + } + .cds--form-item.cds--text-input-wrapper { input { //override styling from carbon @include type-style("productive-heading-02"); color: $text-primary; diff --git a/canvas_modules/common-canvas/src/common-properties/controls/expression/expression-builder/expression-select-field-function.jsx b/canvas_modules/common-canvas/src/common-properties/controls/expression/expression-builder/expression-select-field-function.jsx index 42d7acf606..2d88ac6506 100644 --- a/canvas_modules/common-canvas/src/common-properties/controls/expression/expression-builder/expression-select-field-function.jsx +++ b/canvas_modules/common-canvas/src/common-properties/controls/expression/expression-builder/expression-select-field-function.jsx @@ -18,7 +18,7 @@ import React from "react"; import PropTypes from "prop-types"; import { Add } from "@carbon/react/icons"; import { Button } from "@carbon/react"; -import { Switch, ContentSwitcher, Dropdown } from "@carbon/react"; +import { Switch, ContentSwitcher, Dropdown, Layer } from "@carbon/react"; import FlexibleTable from "./../../../components/flexible-table/flexible-table"; import TruncatedContentTooltip from "./../../../components/truncated-content-tooltip"; import { MESSAGE_KEYS, EXPRESSION_TABLE_ROWS, SORT_DIRECTION, ROW_SELECTION } from "./../../../constants/constants"; @@ -605,15 +605,16 @@ export default class ExpressionSelectFieldOrFunction extends React.Component { }; return (
- listBoxMenuIconTranslationIds[id]} - titleText={header} - /> + + listBoxMenuIconTranslationIds[id]} + titleText={header} + /> +
); } @@ -634,15 +635,16 @@ export default class ExpressionSelectFieldOrFunction extends React.Component { }; return (
- listBoxMenuIconTranslationIds[id]} - titleText={header} - /> + + listBoxMenuIconTranslationIds[id]} + titleText={header} + /> +
); } diff --git a/canvas_modules/common-canvas/src/common-properties/panels/subtabs/subtabs.jsx b/canvas_modules/common-canvas/src/common-properties/panels/subtabs/subtabs.jsx index 414f0d7b40..f355c2b38a 100644 --- a/canvas_modules/common-canvas/src/common-properties/panels/subtabs/subtabs.jsx +++ b/canvas_modules/common-canvas/src/common-properties/panels/subtabs/subtabs.jsx @@ -86,7 +86,6 @@ class Subtabs extends React.Component { > {subTabLists}