fix(treaty2): ws response data type #122
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
EdenWS has the wrong
event.data
type for all subscription-related listeners.Expected
When defining a
response
for the message, Eden should show that same type in theevent.data
for the callback argument inEdenWS.on
,EdenWS.subscribe
, andEdenWS.addEventListener
.Solution
EdenWS
class should providedSchema['response'][200]
as the data type for the second generic argument inTreaty.WSEvent
Minimal Reproduction