fix: params now optional for paramless routes in edenFetch #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredericoo
commented
Jan 3, 2024
| @@ -32,7 +32,7 @@ export namespace EdenFetch { | |||
| : { | |||
| method: Method | |||
| }) & | |||
| (IsNever<keyof Route['params']> extends true | |||
There was a problem hiding this comment.
as Route['params'] is already never, calling keyof never resolves to string | number | symbol, not matching the clause
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40
Note:
We might want to add
"./test/**/*"to tsconfig includes, as this could’ve been caught by tsc or linting the test files. I obviously didn’t do this as part of this PR as it is beyond scope and also highlights other issues (withtransform)