Add support for "parse" lifecycle event for websockets. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntzrbtr
added a commit
to ntzrbtr/documentation
that referenced
this pull request
Apr 9, 2023
This is documentation for elysiajs/elysia#33 and can be merged after that.
|
Sorry for the slow response, I had a vacation the last week and didn't have a chance to check the mail. Back to the topic, right, sounds like the problem with generated code, we will try to improve it in the later version to be more fine-grained in the future, but this is good enough for now. |
|
Should be available in 0.4.9 |
Quals6
added a commit
to Quals6/vitepress
that referenced
this pull request
Aug 5, 2024
This is documentation for elysiajs/elysia#33 and can be merged after that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the clients in my project tries to open a websocket connection with the content type set to "application/json", but without sending a request body. This results in an error in the compiled handler (line 71 in compose.ts), so in order to fix this, I would need support for the "parse" lifecycle event also for websockets.
The other solution would be to do a more fine-grained handling of errors in the generated code in compose.ts, but for now I like the simplicity of the approach with only one try-catch block for everything.