Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 fix: handle error() in resolve with aot: false #889

Conversation

crishoj
Copy link
Contributor

@crishoj crishoj commented Oct 21, 2024

Fixes #888

@SaltyAom — it seems a little inconsistent to sprinkle cases with { aot: false } over the tests. Perhaps you have a more exhaustive approach for full test coverage both with and without AOT?

@SaltyAom SaltyAom merged commit 6811268 into elysiajs:main Nov 14, 2024
@crishoj
Copy link
Contributor Author

crishoj commented Nov 14, 2024

@SaltyAom more generally, I think Elysia maintainers should consider either

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot return error on resolve when set ElysiaConfig aot to false
2 participants