New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(websocket/types): pass full instance and extend context with its … #92

Merged

SaltyAom merged 1 commit into elysiajs:main from hesxenon:59-websocket-should-have-access-to-full-context

Sep 4, 2023

Contributor

hesxenon commented Aug 22, 2023

Since the ElysiaWsContext hasn't been extended with the Instance['request'] websocket handlers didn't have access to derivations and such.

This PR simply passes the full instance instead of just the schema definitions and extends the context with its request type

fixes #59


          fix(websocket/types): pass full instance and extend context with its …

c839ca8

…request

fixes elysiajs#59

Member

SaltyAom commented Sep 4, 2023

This is super helpful!
Thanks a lot!

SaltyAom merged commit ceb1fcd into elysiajs:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet