From c093cf88eac57871b5bf8cd5522f918fc956f1ac Mon Sep 17 00:00:00 2001 From: "Michael Bradley, Jr" Date: Fri, 17 Jan 2020 11:32:32 -0600 Subject: [PATCH] feat: support Node.js v12.x and newer Remove the `<12.0.0` restriction re: Node.js version in the `"engines"` settings for all the packages in the monorepo that had that restriction. Add missing `"engines"` settings in `packages/plugins/snark/package.json`. Adjust the Azure Pipelines config to include builds for Node.js v12.x and v13.x. Bump `solc` to `0.4.26` in `dapps/tests/app` and `dapps/tests/contracts`. It was discovered that older versions suffered a fatal `Maximum call stack size exceeded` error when run on Windows with Node.js v12.x or newer. Display a warning re: the bad combo (solc version + Windows + Node version) if it's detected at runtime. Adjust the root `yarn.lock` so that the `sha3` transitive dependency resolves to a newer version that is compatible with Node v13.x. --- azure-pipelines.yml | 20 +++++++++++++++++++ dapps/tests/app/embark.json | 2 +- dapps/tests/contracts/contracts.json | 2 +- dapps/tests/contracts/embark.json | 2 +- package.json | 2 +- packages/cockpit/api-client/package.json | 2 +- packages/cockpit/ui/package.json | 2 +- packages/core/code-runner/package.json | 2 +- packages/core/console/package.json | 2 +- packages/core/core/package.json | 2 +- packages/core/engine/package.json | 2 +- packages/core/i18n/package.json | 2 +- packages/core/logger/package.json | 2 +- packages/core/reset/package.json | 2 +- packages/core/utils/package.json | 2 +- packages/embark/package.json | 4 ++-- packages/embarkjs/embarkjs/package.json | 2 +- packages/embarkjs/ens/package.json | 2 +- packages/embarkjs/ipfs/package.json | 2 +- packages/embarkjs/swarm/package.json | 2 +- packages/embarkjs/web3/package.json | 2 +- packages/embarkjs/whisper/package.json | 2 +- .../plugins/accounts-manager/package.json | 2 +- packages/plugins/basic-pipeline/package.json | 2 +- packages/plugins/coverage/package.json | 2 +- packages/plugins/debugger/package.json | 2 +- packages/plugins/deploy-tracker/package.json | 2 +- packages/plugins/ens/package.json | 2 +- .../ethereum-blockchain-client/package.json | 2 +- packages/plugins/ganache/package.json | 2 +- packages/plugins/geth/package.json | 2 +- packages/plugins/graph/package.json | 2 +- packages/plugins/ipfs/package.json | 2 +- packages/plugins/mocha-tests/package.json | 2 +- packages/plugins/nethermind/package.json | 2 +- packages/plugins/parity/package.json | 2 +- packages/plugins/plugin-cmd/package.json | 2 +- packages/plugins/profiler/package.json | 2 +- packages/plugins/rpc-manager/package.json | 2 +- packages/plugins/scaffolding/package.json | 2 +- packages/plugins/snark/package.json | 5 +++++ packages/plugins/solc/package.json | 2 +- packages/plugins/solidity-tests/package.json | 2 +- packages/plugins/solidity/package.json | 2 +- packages/plugins/solidity/src/solcW.js | 9 +++++++++ packages/plugins/specialconfigs/package.json | 2 +- packages/plugins/swarm/package.json | 2 +- .../plugins/transaction-logger/package.json | 2 +- .../plugins/transaction-tracker/package.json | 2 +- packages/plugins/vyper/package.json | 2 +- packages/plugins/web3/package.json | 2 +- packages/plugins/whisper-geth/package.json | 2 +- packages/plugins/whisper-parity/package.json | 2 +- packages/stack/api/package.json | 2 +- packages/stack/authenticator/package.json | 2 +- packages/stack/blockchain-client/package.json | 2 +- packages/stack/blockchain/package.json | 2 +- packages/stack/communication/package.json | 2 +- packages/stack/compiler/package.json | 2 +- packages/stack/contracts-manager/package.json | 2 +- packages/stack/deployment/package.json | 2 +- packages/stack/embarkjs/package.json | 2 +- packages/stack/library-manager/package.json | 2 +- packages/stack/namesystem/package.json | 2 +- packages/stack/pipeline/package.json | 2 +- .../process-logs-api-manager/package.json | 2 +- packages/stack/proxy/package.json | 2 +- packages/stack/storage/package.json | 2 +- packages/stack/test-runner/package.json | 2 +- packages/stack/watcher/package.json | 2 +- packages/stack/webserver/package.json | 2 +- packages/utils/collective/package.json | 2 +- packages/utils/inside-monorepo/package.json | 2 +- packages/utils/solo/package.json | 2 +- packages/utils/testing/package.json | 2 +- yarn.lock | 6 +++--- 76 files changed, 110 insertions(+), 76 deletions(-) diff --git a/azure-pipelines.yml b/azure-pipelines.yml index 4dd13bf370..b75269e4a3 100644 --- a/azure-pipelines.yml +++ b/azure-pipelines.yml @@ -5,6 +5,8 @@ variables: YARN_CACHE_FOLDER: $(Pipeline.Workspace)/.yarn ipfsVersion: '0.4.22' node10: '^10.17.0' + node12: '^12.0.0' + node13: '^13.0.0' pythonVersion: '2.7.x' yarnVersion: '1.19.1' @@ -19,6 +21,24 @@ strategy: Node 10 / Windows: nodeVersion: $(node10) imageName: 'vs2017-win2016' + Node 12 / Linux: + nodeVersion: $(node12) + imageName: 'ubuntu-18.04' + Node 12 / macOS: + nodeVersion: $(node12) + imageName: 'macos-10.14' + Node 12 / Windows: + nodeVersion: $(node12) + imageName: 'vs2017-win2016' + Node 13 / Linux: + nodeVersion: $(node13) + imageName: 'ubuntu-18.04' + Node 13 / macOS: + nodeVersion: $(node13) + imageName: 'macos-10.14' + Node 13 / Windows: + nodeVersion: $(node13) + imageName: 'vs2017-win2016' pool: vmImage: $(imageName) diff --git a/dapps/tests/app/embark.json b/dapps/tests/app/embark.json index ed295ea298..cef864cbcd 100644 --- a/dapps/tests/app/embark.json +++ b/dapps/tests/app/embark.json @@ -15,7 +15,7 @@ "buildDir": "dist/", "config": "config/", "versions": { - "solc": "0.4.25" + "solc": "0.4.26" }, "plugins": { "embark-dapp-test-service": {} diff --git a/dapps/tests/contracts/contracts.json b/dapps/tests/contracts/contracts.json index 12da84b9bc..2c878441e1 100644 --- a/dapps/tests/contracts/contracts.json +++ b/dapps/tests/contracts/contracts.json @@ -1,7 +1,7 @@ { "default": { "versions": { - "solc": "0.4.24" + "solc": "0.4.26" }, "dappConnection": [ "$EMBARK", diff --git a/dapps/tests/contracts/embark.json b/dapps/tests/contracts/embark.json index 35e833943f..ceeb5deb39 100644 --- a/dapps/tests/contracts/embark.json +++ b/dapps/tests/contracts/embark.json @@ -12,7 +12,7 @@ "namesystem": "ens.json" }, "versions": { - "solc": "0.4.24" + "solc": "0.4.26" }, "plugins": { } diff --git a/package.json b/package.json index cab4e46f6c..2c3716313a 100644 --- a/package.json +++ b/package.json @@ -16,7 +16,7 @@ "semver": "5.6.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" }, diff --git a/packages/cockpit/api-client/package.json b/packages/cockpit/api-client/package.json index 5b763ea225..90c65fd731 100644 --- a/packages/cockpit/api-client/package.json +++ b/packages/cockpit/api-client/package.json @@ -56,7 +56,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/cockpit/ui/package.json b/packages/cockpit/ui/package.json index f22e383617..cdda33b52d 100644 --- a/packages/cockpit/ui/package.json +++ b/packages/cockpit/ui/package.json @@ -120,7 +120,7 @@ ] }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/core/code-runner/package.json b/packages/core/code-runner/package.json index 50ecc97a3d..df35e8fe78 100644 --- a/packages/core/code-runner/package.json +++ b/packages/core/code-runner/package.json @@ -74,7 +74,7 @@ "typescript": "3.7.2" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" }, diff --git a/packages/core/console/package.json b/packages/core/console/package.json index 15eb5f38c5..315065a7bf 100644 --- a/packages/core/console/package.json +++ b/packages/core/console/package.json @@ -72,7 +72,7 @@ "typescript": "3.7.2" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" }, diff --git a/packages/core/core/package.json b/packages/core/core/package.json index 8476569fef..e597764a0d 100644 --- a/packages/core/core/package.json +++ b/packages/core/core/package.json @@ -79,7 +79,7 @@ "typescript": "3.7.2" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/core/engine/package.json b/packages/core/engine/package.json index 44e0d87928..e2bc518fa4 100644 --- a/packages/core/engine/package.json +++ b/packages/core/engine/package.json @@ -103,7 +103,7 @@ "typescript": "3.7.2" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/core/i18n/package.json b/packages/core/i18n/package.json index 1f920d2b80..f977a36991 100644 --- a/packages/core/i18n/package.json +++ b/packages/core/i18n/package.json @@ -58,7 +58,7 @@ "typescript": "3.7.2" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/core/logger/package.json b/packages/core/logger/package.json index 76cc0d6fda..d8b90b6309 100644 --- a/packages/core/logger/package.json +++ b/packages/core/logger/package.json @@ -56,7 +56,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/core/reset/package.json b/packages/core/reset/package.json index 4816592da2..1620c2e087 100644 --- a/packages/core/reset/package.json +++ b/packages/core/reset/package.json @@ -39,7 +39,7 @@ "npm-run-all": "4.1.5" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/core/utils/package.json b/packages/core/utils/package.json index ab23a3dd72..8571494819 100644 --- a/packages/core/utils/package.json +++ b/packages/core/utils/package.json @@ -84,7 +84,7 @@ "typescript": "3.7.2" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/embark/package.json b/packages/embark/package.json index 5776f81e8f..bf59e78657 100644 --- a/packages/embark/package.json +++ b/packages/embark/package.json @@ -158,13 +158,13 @@ "sinon": "4.5.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" }, "runtime": { "engines": { - "node": ">=10.17.0 <12.0.0" + "node": ">=10.17.0" } } } diff --git a/packages/embarkjs/embarkjs/package.json b/packages/embarkjs/embarkjs/package.json index 860b58ddd0..061b7e6ce5 100644 --- a/packages/embarkjs/embarkjs/package.json +++ b/packages/embarkjs/embarkjs/package.json @@ -82,7 +82,7 @@ "web3": "1.2.4" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/embarkjs/ens/package.json b/packages/embarkjs/ens/package.json index 22df444a3e..b195b9c69e 100644 --- a/packages/embarkjs/ens/package.json +++ b/packages/embarkjs/ens/package.json @@ -61,7 +61,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/embarkjs/ipfs/package.json b/packages/embarkjs/ipfs/package.json index 6e36f71faf..747b887e7b 100644 --- a/packages/embarkjs/ipfs/package.json +++ b/packages/embarkjs/ipfs/package.json @@ -59,7 +59,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/embarkjs/swarm/package.json b/packages/embarkjs/swarm/package.json index 9594ffc82d..ab4d767054 100644 --- a/packages/embarkjs/swarm/package.json +++ b/packages/embarkjs/swarm/package.json @@ -60,7 +60,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/embarkjs/web3/package.json b/packages/embarkjs/web3/package.json index 6b76d92e9a..5e7207f2ce 100644 --- a/packages/embarkjs/web3/package.json +++ b/packages/embarkjs/web3/package.json @@ -59,7 +59,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/embarkjs/whisper/package.json b/packages/embarkjs/whisper/package.json index 61c819e674..9c0a2aae3f 100644 --- a/packages/embarkjs/whisper/package.json +++ b/packages/embarkjs/whisper/package.json @@ -60,7 +60,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/plugins/accounts-manager/package.json b/packages/plugins/accounts-manager/package.json index 65e81a1085..0eed571c8c 100644 --- a/packages/plugins/accounts-manager/package.json +++ b/packages/plugins/accounts-manager/package.json @@ -63,7 +63,7 @@ "typescript": "3.7.2" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/plugins/basic-pipeline/package.json b/packages/plugins/basic-pipeline/package.json index 49dbd54fc4..cd28736aed 100644 --- a/packages/plugins/basic-pipeline/package.json +++ b/packages/plugins/basic-pipeline/package.json @@ -96,7 +96,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" }, diff --git a/packages/plugins/coverage/package.json b/packages/plugins/coverage/package.json index 220d768e04..4a9a20c2a1 100644 --- a/packages/plugins/coverage/package.json +++ b/packages/plugins/coverage/package.json @@ -73,7 +73,7 @@ "typescript": "3.7.2" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/plugins/debugger/package.json b/packages/plugins/debugger/package.json index 5184b32ad0..96e64450a8 100644 --- a/packages/plugins/debugger/package.json +++ b/packages/plugins/debugger/package.json @@ -57,7 +57,7 @@ "typescript": "3.7.2" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/plugins/deploy-tracker/package.json b/packages/plugins/deploy-tracker/package.json index b4c9814b22..9803846d15 100644 --- a/packages/plugins/deploy-tracker/package.json +++ b/packages/plugins/deploy-tracker/package.json @@ -62,7 +62,7 @@ "sinon": "7.4.1" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" }, diff --git a/packages/plugins/ens/package.json b/packages/plugins/ens/package.json index 99d09c3601..8d84fe5188 100644 --- a/packages/plugins/ens/package.json +++ b/packages/plugins/ens/package.json @@ -95,7 +95,7 @@ } }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/plugins/ethereum-blockchain-client/package.json b/packages/plugins/ethereum-blockchain-client/package.json index cc4137ff5a..37268e1ca9 100644 --- a/packages/plugins/ethereum-blockchain-client/package.json +++ b/packages/plugins/ethereum-blockchain-client/package.json @@ -62,7 +62,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/plugins/ganache/package.json b/packages/plugins/ganache/package.json index 1229c79711..ab482d2b18 100644 --- a/packages/plugins/ganache/package.json +++ b/packages/plugins/ganache/package.json @@ -55,7 +55,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/plugins/geth/package.json b/packages/plugins/geth/package.json index 9416f10596..dce64a732c 100644 --- a/packages/plugins/geth/package.json +++ b/packages/plugins/geth/package.json @@ -68,7 +68,7 @@ "typescript": "3.7.2" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/plugins/graph/package.json b/packages/plugins/graph/package.json index 12772a9fc2..ca4d429709 100644 --- a/packages/plugins/graph/package.json +++ b/packages/plugins/graph/package.json @@ -56,7 +56,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/plugins/ipfs/package.json b/packages/plugins/ipfs/package.json index 1444febacf..13de607a2a 100644 --- a/packages/plugins/ipfs/package.json +++ b/packages/plugins/ipfs/package.json @@ -66,7 +66,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/plugins/mocha-tests/package.json b/packages/plugins/mocha-tests/package.json index dd2ba59feb..4fbc1b36b3 100644 --- a/packages/plugins/mocha-tests/package.json +++ b/packages/plugins/mocha-tests/package.json @@ -68,7 +68,7 @@ "source-map-support": "0.5.13" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/plugins/nethermind/package.json b/packages/plugins/nethermind/package.json index 82ff846ffa..9dfdfd7f68 100644 --- a/packages/plugins/nethermind/package.json +++ b/packages/plugins/nethermind/package.json @@ -60,7 +60,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/plugins/parity/package.json b/packages/plugins/parity/package.json index bdf4cd753f..effac98144 100644 --- a/packages/plugins/parity/package.json +++ b/packages/plugins/parity/package.json @@ -62,7 +62,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/plugins/plugin-cmd/package.json b/packages/plugins/plugin-cmd/package.json index 5ec0c30540..0a9b168729 100644 --- a/packages/plugins/plugin-cmd/package.json +++ b/packages/plugins/plugin-cmd/package.json @@ -48,7 +48,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/plugins/profiler/package.json b/packages/plugins/profiler/package.json index 4d6f20919d..de281d7e76 100644 --- a/packages/plugins/profiler/package.json +++ b/packages/plugins/profiler/package.json @@ -58,7 +58,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/plugins/rpc-manager/package.json b/packages/plugins/rpc-manager/package.json index 986290303a..5fb1e6167f 100644 --- a/packages/plugins/rpc-manager/package.json +++ b/packages/plugins/rpc-manager/package.json @@ -67,7 +67,7 @@ "typescript": "3.7.2" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" }, diff --git a/packages/plugins/scaffolding/package.json b/packages/plugins/scaffolding/package.json index 9fe3ca1b79..9e0ab3a35d 100644 --- a/packages/plugins/scaffolding/package.json +++ b/packages/plugins/scaffolding/package.json @@ -64,7 +64,7 @@ "typescript": "3.7.2" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/plugins/snark/package.json b/packages/plugins/snark/package.json index 96e5ade39f..f2364cf442 100644 --- a/packages/plugins/snark/package.json +++ b/packages/plugins/snark/package.json @@ -101,5 +101,10 @@ }, "prettier": { "singleQuote": true + }, + "engines": { + "node": ">=10.17.0", + "npm": ">=6.11.3", + "yarn": ">=1.19.1" } } diff --git a/packages/plugins/solc/package.json b/packages/plugins/solc/package.json index 0359b550da..c8760f82d2 100644 --- a/packages/plugins/solc/package.json +++ b/packages/plugins/solc/package.json @@ -57,7 +57,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/plugins/solidity-tests/package.json b/packages/plugins/solidity-tests/package.json index 02dc658382..91d36e9deb 100644 --- a/packages/plugins/solidity-tests/package.json +++ b/packages/plugins/solidity-tests/package.json @@ -69,7 +69,7 @@ "source-map-support": "0.5.13" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/plugins/solidity/package.json b/packages/plugins/solidity/package.json index e756f34542..9afe638789 100644 --- a/packages/plugins/solidity/package.json +++ b/packages/plugins/solidity/package.json @@ -62,7 +62,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/plugins/solidity/src/solcW.js b/packages/plugins/solidity/src/solcW.js index 7a912b670a..3def2430ea 100644 --- a/packages/plugins/solidity/src/solcW.js +++ b/packages/plugins/solidity/src/solcW.js @@ -1,6 +1,7 @@ import { __ } from 'embark-i18n'; import { ProcessLauncher } from 'embark-core'; import { dappPath, joinPath, toForwardSlashes } from 'embark-utils'; +const semver = require('semver'); const uuid = require('uuid/v1'); class SolcW { @@ -69,6 +70,14 @@ class SolcW { this.solcProcess.once("result", "initiated", () => { this.events.request("version:get:solc", (solcVersion) => { + if (semver.lte(solcVersion, '0.4.25') && + process.platform === 'win32' && + semver.gte(process.version, '12.0.0')) { + this.logger.warn([ + 'Versions of the solc package older than 0.4.26 are known to have', + 'problems running on Windows with Node.js v12.x and newer.' + ].join(' ')); + } if (solcVersion === this.embark.config.package.dependencies.solc) { return this.solcProcess.send({action: 'loadCompiler', requirePath: 'solc'}); } diff --git a/packages/plugins/specialconfigs/package.json b/packages/plugins/specialconfigs/package.json index 66898ffb55..5549c00ba7 100644 --- a/packages/plugins/specialconfigs/package.json +++ b/packages/plugins/specialconfigs/package.json @@ -57,7 +57,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/plugins/swarm/package.json b/packages/plugins/swarm/package.json index 6dde630f88..45fb880e92 100644 --- a/packages/plugins/swarm/package.json +++ b/packages/plugins/swarm/package.json @@ -66,7 +66,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/plugins/transaction-logger/package.json b/packages/plugins/transaction-logger/package.json index da9592cacc..26cdbe057f 100644 --- a/packages/plugins/transaction-logger/package.json +++ b/packages/plugins/transaction-logger/package.json @@ -66,7 +66,7 @@ "typescript": "3.7.2" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/plugins/transaction-tracker/package.json b/packages/plugins/transaction-tracker/package.json index 4f1143c9a9..dc5988bcac 100644 --- a/packages/plugins/transaction-tracker/package.json +++ b/packages/plugins/transaction-tracker/package.json @@ -56,7 +56,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/plugins/vyper/package.json b/packages/plugins/vyper/package.json index 73aeb4d0b5..d50d3eeffd 100644 --- a/packages/plugins/vyper/package.json +++ b/packages/plugins/vyper/package.json @@ -57,7 +57,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/plugins/web3/package.json b/packages/plugins/web3/package.json index debd3ce441..1a52406057 100644 --- a/packages/plugins/web3/package.json +++ b/packages/plugins/web3/package.json @@ -61,7 +61,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/plugins/whisper-geth/package.json b/packages/plugins/whisper-geth/package.json index d05cd793a9..9072d99d2b 100644 --- a/packages/plugins/whisper-geth/package.json +++ b/packages/plugins/whisper-geth/package.json @@ -61,7 +61,7 @@ "web3": "1.2.4" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/plugins/whisper-parity/package.json b/packages/plugins/whisper-parity/package.json index ef94a057d2..4078af3cab 100644 --- a/packages/plugins/whisper-parity/package.json +++ b/packages/plugins/whisper-parity/package.json @@ -61,7 +61,7 @@ "web3": "1.2.4" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/stack/api/package.json b/packages/stack/api/package.json index 987f31b0a3..f542260a87 100644 --- a/packages/stack/api/package.json +++ b/packages/stack/api/package.json @@ -69,7 +69,7 @@ "typescript": "3.7.2" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/stack/authenticator/package.json b/packages/stack/authenticator/package.json index d25f12e1dd..d9114fb3ce 100644 --- a/packages/stack/authenticator/package.json +++ b/packages/stack/authenticator/package.json @@ -58,7 +58,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/stack/blockchain-client/package.json b/packages/stack/blockchain-client/package.json index f0219a1965..76f9388ff4 100644 --- a/packages/stack/blockchain-client/package.json +++ b/packages/stack/blockchain-client/package.json @@ -55,7 +55,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/stack/blockchain/package.json b/packages/stack/blockchain/package.json index 28c118abe5..b1ff449ea6 100644 --- a/packages/stack/blockchain/package.json +++ b/packages/stack/blockchain/package.json @@ -69,7 +69,7 @@ "typescript": "3.7.2" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" }, diff --git a/packages/stack/communication/package.json b/packages/stack/communication/package.json index 84a40fe037..8ad5c99ab9 100644 --- a/packages/stack/communication/package.json +++ b/packages/stack/communication/package.json @@ -64,7 +64,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" }, diff --git a/packages/stack/compiler/package.json b/packages/stack/compiler/package.json index ec886111a0..320a20368a 100644 --- a/packages/stack/compiler/package.json +++ b/packages/stack/compiler/package.json @@ -63,7 +63,7 @@ "typescript": "3.7.2" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" }, diff --git a/packages/stack/contracts-manager/package.json b/packages/stack/contracts-manager/package.json index 36b54fef6e..17dd8d2e60 100644 --- a/packages/stack/contracts-manager/package.json +++ b/packages/stack/contracts-manager/package.json @@ -66,7 +66,7 @@ "typescript": "3.7.2" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/stack/deployment/package.json b/packages/stack/deployment/package.json index 84659d58b7..87cfd656c1 100644 --- a/packages/stack/deployment/package.json +++ b/packages/stack/deployment/package.json @@ -64,7 +64,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" }, diff --git a/packages/stack/embarkjs/package.json b/packages/stack/embarkjs/package.json index 7303acdd12..c49e6937b4 100644 --- a/packages/stack/embarkjs/package.json +++ b/packages/stack/embarkjs/package.json @@ -57,7 +57,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/stack/library-manager/package.json b/packages/stack/library-manager/package.json index edc10dc8c5..7f2bf1e891 100644 --- a/packages/stack/library-manager/package.json +++ b/packages/stack/library-manager/package.json @@ -60,7 +60,7 @@ "web3": "1.2.4" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/stack/namesystem/package.json b/packages/stack/namesystem/package.json index b233008695..ff9a360a29 100644 --- a/packages/stack/namesystem/package.json +++ b/packages/stack/namesystem/package.json @@ -56,7 +56,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/stack/pipeline/package.json b/packages/stack/pipeline/package.json index 58463ecd43..f42c2fcc9e 100644 --- a/packages/stack/pipeline/package.json +++ b/packages/stack/pipeline/package.json @@ -61,7 +61,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/stack/process-logs-api-manager/package.json b/packages/stack/process-logs-api-manager/package.json index 5ddb101274..0f8fddb8a4 100644 --- a/packages/stack/process-logs-api-manager/package.json +++ b/packages/stack/process-logs-api-manager/package.json @@ -55,7 +55,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/stack/proxy/package.json b/packages/stack/proxy/package.json index 8eafaa014e..6310f80158 100644 --- a/packages/stack/proxy/package.json +++ b/packages/stack/proxy/package.json @@ -69,7 +69,7 @@ "typescript": "3.7.2" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/stack/storage/package.json b/packages/stack/storage/package.json index e0b94df4f0..17c9f99112 100644 --- a/packages/stack/storage/package.json +++ b/packages/stack/storage/package.json @@ -61,7 +61,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/stack/test-runner/package.json b/packages/stack/test-runner/package.json index 0c080dcbc6..df06088fea 100644 --- a/packages/stack/test-runner/package.json +++ b/packages/stack/test-runner/package.json @@ -76,7 +76,7 @@ "source-map-support": "0.5.13" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/stack/watcher/package.json b/packages/stack/watcher/package.json index 7e772d30c5..50975535d3 100644 --- a/packages/stack/watcher/package.json +++ b/packages/stack/watcher/package.json @@ -57,7 +57,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/stack/webserver/package.json b/packages/stack/webserver/package.json index d04ba9e54f..a28a0db127 100644 --- a/packages/stack/webserver/package.json +++ b/packages/stack/webserver/package.json @@ -64,7 +64,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/utils/collective/package.json b/packages/utils/collective/package.json index c4f547c6e6..da4ce0decf 100644 --- a/packages/utils/collective/package.json +++ b/packages/utils/collective/package.json @@ -71,7 +71,7 @@ "typescript": "3.7.2" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/utils/inside-monorepo/package.json b/packages/utils/inside-monorepo/package.json index bc8e08e96a..4cba5fa20c 100644 --- a/packages/utils/inside-monorepo/package.json +++ b/packages/utils/inside-monorepo/package.json @@ -14,7 +14,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/utils/solo/package.json b/packages/utils/solo/package.json index 31a0180f26..e8f502963e 100644 --- a/packages/utils/solo/package.json +++ b/packages/utils/solo/package.json @@ -19,7 +19,7 @@ "rimraf": "3.0.0" }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/packages/utils/testing/package.json b/packages/utils/testing/package.json index 9bf772dda2..558912d550 100644 --- a/packages/utils/testing/package.json +++ b/packages/utils/testing/package.json @@ -81,7 +81,7 @@ } }, "engines": { - "node": ">=10.17.0 <12.0.0", + "node": ">=10.17.0", "npm": ">=6.11.3", "yarn": ">=1.19.1" } diff --git a/yarn.lock b/yarn.lock index 24a739f5eb..aacecaf0d8 100644 --- a/yarn.lock +++ b/yarn.lock @@ -19082,9 +19082,9 @@ sha.js@^2.4.0, sha.js@^2.4.8: safe-buffer "^5.0.1" sha3@^1.2.2: - version "1.2.3" - resolved "https://registry.yarnpkg.com/sha3/-/sha3-1.2.3.tgz#ed5958fa8331df1b1b8529ca9fdf225a340c5418" - integrity sha512-sOWDZi8cDBRkLfWOw18wvJyNblXDHzwMGnRWut8zNNeIeLnmMRO17bjpLc7OzMuj1ASUgx2IyohzUCAl+Kx5vA== + version "1.2.6" + resolved "https://registry.yarnpkg.com/sha3/-/sha3-1.2.6.tgz#102aa3e47dc793e2357902c3cce8760822f9e905" + integrity sha512-KgLGmJGrmNB4JWVsAV11Yk6KbvsAiygWJc7t5IebWva/0NukNrjJqhtKhzy3Eiv2AKuGvhZZt7dt1mDo7HkoiQ== dependencies: nan "2.13.2"