-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ProjectWideDependencyChecker check
API
#206
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
commented
May 7, 2020
runspired
approved these changes
May 7, 2020
xg-wang
reviewed
May 7, 2020
3 tasks
stefanpenner
force-pushed
the
pw-check
branch
5 times, most recently
from
May 11, 2020 21:12
cb527d7
to
a9d7642
Compare
scalvert
suggested changes
May 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small changes, but otherwise looks good!
hjdivad
reviewed
May 11, 2020
rwjblue
approved these changes
May 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor tweaks, LGTM
This allows someone to make broader assertions against the project’s dependencies. ```js const checker VersionChecker.forProject(project); checker.check({ ‘ember-data’: ‘>= 3.16.0’, ‘ember-resolver’: ‘*’, }) === { isSatisfied: true | false, message: ‘’ || ‘useful canned error message’, node_modules: { ‘ember-data’: { isSatisfied: true | false, message: ‘’ || ‘useful canned error message’, Versions: [/* list of versions found */] }, ‘Ember-resolver: { /* basically same as ember-datas blob */ }, assert(message?) { } // throw a canned error, with an optional description } } ``` This Commit also fixes/cleans up the testing infrastructure to simplify the testing of the above new feature
released as v5.1.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ProjectWideDependencyChecker
check
APIThis allows someone to make broader assertions against the project’s dependencies. The goal here is to handle the complexity of making these assertions here in ember-cli-version-checker.
Example:
This Commit also fixes/cleans up the testing infrastructure to simplify the testing of the above new feature
TODO:
filterAddonsByNames
for good measure