From 8620f7983fb2daf62f0c66dfa76d7300658cd314 Mon Sep 17 00:00:00 2001 From: Chris Manson Date: Fri, 20 Dec 2024 11:41:09 +0000 Subject: [PATCH] use npx to execute ember - fix node resolution --- .github/workflows/ci.yml | 50 ++++++++++++++++++++-------------------- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a23eef45..46ce1206 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -86,63 +86,63 @@ jobs: matrix: command: # try:each - - ./node_modules/.bin/ember try:each + - npx ember try:each # skip-cleanup option - - ./node_modules/.bin/ember try:each --skip-cleanup + - npx ember try:each --skip-cleanup # config-path option - - ./node_modules/.bin/ember try:each --config-path='../test/fixtures/dummy-ember-try-config.js' + - npx ember try:each --config-path='../test/fixtures/dummy-ember-try-config.js' # both ember-try options - - ./node_modules/.bin/ember try:each --config-path='../test/fixtures/dummy-ember-try-config.js' --skip-cleanup true + - npx ember try:each --config-path='../test/fixtures/dummy-ember-try-config.js' --skip-cleanup true # try:ember - - ./node_modules/.bin/ember try:ember '> 4.10.0 < 5.2.0' - - ./node_modules/.bin/ember try:ember '4.9.0' --config-path='../test/fixtures/dummy-ember-try-config.js' - - ./node_modules/.bin/ember try:ember '4.8.3' --skip-cleanup=true + - npx ember try:ember '> 4.10.0 < 5.2.0' + - npx ember try:ember '4.9.0' --config-path='../test/fixtures/dummy-ember-try-config.js' + - npx ember try:ember '4.8.3' --skip-cleanup=true # try:config - - ./node_modules/.bin/ember try:config - - ./node_modules/.bin/ember try:config --config-path='../test/fixtures/dummy-ember-try-config.js' + - npx ember try:config + - npx ember try:config --config-path='../test/fixtures/dummy-ember-try-config.js' # try:one - - ./node_modules/.bin/ember try:one default + - npx ember try:one default # custom command - - ./node_modules/.bin/ember try:one default --- ember help + - npx ember try:one default --- ember help # skip-cleanup option - - ./node_modules/.bin/ember try:one default --skip-cleanup + - npx ember try:one default --skip-cleanup # config-path option - - ./node_modules/.bin/ember try:one test1 --config-path='../test/fixtures/dummy-ember-try-config.js' + - npx ember try:one test1 --config-path='../test/fixtures/dummy-ember-try-config.js' # both ember-try options - - ./node_modules/.bin/ember try:one test1 --config-path='../test/fixtures/dummy-ember-try-config.js' --skip-cleanup true + - npx ember try:one test1 --config-path='../test/fixtures/dummy-ember-try-config.js' --skip-cleanup true # custom command with options to command - - ./node_modules/.bin/ember try:one default --- ember help --silent + - npx ember try:one default --- ember help --silent # custom command mixed with ember try's own option - - ./node_modules/.bin/ember try:one default --skip-cleanup --- ember help --silent + - npx ember try:one default --skip-cleanup --- ember help --silent # try:reset - - ./node_modules/.bin/ember try:reset + - npx ember try:reset # Environment variables availability - - FOO="5" ./node_modules/.bin/ember try:one default --- ./fail-if-no-foo.sh + - FOO="5" npx ember try:one default --- ./fail-if-no-foo.sh - - ./node_modules/.bin/ember try:one default --- FOO=5 ./fail-if-no-foo.sh + - npx ember try:one default --- FOO=5 ./fail-if-no-foo.sh # Custom, compound commands - - ./node_modules/.bin/ember try:one default --- 'echo 1 && echo 2' + - npx ember try:one default --- 'echo 1 && echo 2' # Environment variables from config - - ./node_modules/.bin/ember try:each --config-path='../test/fixtures/dummy-ember-try-config-different-env-vars.js' + - npx ember try:each --config-path='../test/fixtures/dummy-ember-try-config-different-env-vars.js' # fs-extra versions 7.x and above caused a regresion - - ./node_modules/.bin/ember try:each --config-path='../test/fixtures/dummy-ember-try-config-fs-extra-scenarios.js' + - npx ember try:each --config-path='../test/fixtures/dummy-ember-try-config-fs-extra-scenarios.js' steps: - uses: actions/checkout@v4 @@ -189,7 +189,7 @@ jobs: - name: install smoke-test-app deps run: npm install working-directory: smoke-test-app - - run: ./node_modules/.bin/ember try:one test2 --config-path='../test/fixtures/dummy-ember-try-config-with-npm-scenarios.js' + - run: npx ember try:one test2 --config-path='../test/fixtures/dummy-ember-try-config-with-npm-scenarios.js' working-directory: smoke-test-app yarn-smoke-tests: @@ -221,7 +221,7 @@ jobs: - name: install smoke-test-app deps run: yarn install working-directory: smoke-test-app - - run: ./node_modules/.bin/ember try:one test2 --config-path='../test/fixtures/dummy-ember-try-config-with-yarn-scenarios.js' + - run: npx ember try:one test2 --config-path='../test/fixtures/dummy-ember-try-config-with-yarn-scenarios.js' working-directory: smoke-test-app windows-smoke-tests: @@ -248,5 +248,5 @@ jobs: - name: install smoke-test-app deps run: npm install working-directory: smoke-test-app - - run: ./node_modules/.bin/ember try:one test2 --config-path='../test/fixtures/dummy-ember-try-config-with-npm-scenarios.js' + - run: npx ember try:one test2 --config-path='../test/fixtures/dummy-ember-try-config-with-npm-scenarios.js' working-directory: smoke-test-app