Add eslint and use ES6 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bardzusny
reviewed
Feb 16, 2017
|
|
||
| var ember = require(resolve(__dirname, 'lib/utils/ember')); | ||
| var utils = require(resolve(__dirname, 'lib/utils/utils')); | ||
| /* eslint-disable import/no-dynamic-require */ |
There was a problem hiding this comment.
Maybe it makes sense to disable it globally, in our case?
There was a problem hiding this comment.
this is literally the only place with dynamic requires, and for a clear reason. In other places we'd rather want to be explicit about this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #17
This PR: