Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rules to new ESLint rule format #54

Merged
merged 3 commits into from
Apr 21, 2017

Conversation

SaladFork
Copy link
Contributor

See: http://eslint.org/blog/2016/07/eslint-new-rule-format

This was done automatically using eslint-transforms.

Ideally we would also add metadata to each rule, but this seemed like a good first step that can be followed up with additional PRs.

Copy link
Member

@michalsnik michalsnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I thought about it too recently. I'm really happy you picked it up and I think it's a great first step.

Copy link
Contributor

@kevinkucharczyk kevinkucharczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@michalsnik michalsnik merged commit a9bc107 into ember-cli:master Apr 21, 2017
@SaladFork SaladFork deleted the new-eslint-rule-format branch April 21, 2017 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants