Update no-test-import-export rule to allow importing from anything under tests/helpers path
#895
Conversation
…under tests/helpers path
| importSource.startsWith('tests/helpers/') || | ||
| importSource.includes('/tests/helpers/') || | ||
| importSource.endsWith('/tests/helpers') || | ||
| importSource === 'tests/helpers' |
There was a problem hiding this comment.
Is it valid for tests/helpers to be a single file instead of a directory?
There was a problem hiding this comment.
Not sure. I suppose this line would handle either a file named tests/helpers.js or a file named tests/helpers/index.js.
There was a problem hiding this comment.
Is it valid for tests/helpers to be a single file instead of a directory?
Yes, it is definitely possible (and allowed) to use a single tests/helpers.js file or a tests/helpers/index.js file.
| @@ -42,7 +45,7 @@ module.exports = { | |||
| ImportDeclaration(node) { | |||
| const importSource = node.source.value; | |||
|
|
|||
| if (importSource.endsWith('-test')) { | |||
| if (importSource.endsWith('-test') && !isTestHelperImportSource(importSource)) { | |||
There was a problem hiding this comment.
Hmm, I'm not 100% sure this is correct. We shouldn't be importing from tests/helpers/something-test.js (e.g. I think the first condition was fine, any file ending with -test is itself a test file not a helper file).
There was a problem hiding this comment.
I see why it was done. If you literally write a module like tests/helpers/some-verb-test.js it would still error.
| }, | ||
|
|
||
| // Importing anything from tests/helpers is allowed. | ||
| "import setupApplicationTest from 'tests/helpers/setup-application-test.js';", |
There was a problem hiding this comment.
We are missing relative path test case, for example:
../../helpers/setup-application-test.js
--
I upgraded eslint-plugin-ember to v8.10.1 and my ESLint still complains about imports from helpers folder, because relative import paths are being used.
I can workaround by changing to absolute path (TypeScript app), like myapp/tests/helpers/.
It seems plugin should resolve real path on disk with path.resolve or something to determine truthiness in isTestHelperFilename method.
Fixes #889.
CC: @mongoose700 @raido