Mention npm scripts, per RFC-831 #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We aim to teach the use of npm/yarn scripts in addition to bare CLI commands, since in real-world applications, developers may have different configurations specified in package.json scripts than the default commands would provide.
✅ Deploy Preview for ember-cli-guides ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kategengler
approved these changes
Sep 18, 2023
kategengler
approved these changes
Sep 18, 2023
| @@ -1,6 +1,6 @@ | |||
| <!-- alex disable just --> | |||
| For most Ember applications, Ember CLI "just works". Run `ember server` in your Terminal and you get | |||
| a LiveReload development server at `http://localhost:4200`. Run `ember build`, and you get a `dist/` | |||
| For most Ember applications, Ember CLI "just works". Run `ember server` or `npm start` in your Terminal and you get | |||
There was a problem hiding this comment.
Can we make it more generalised like use package manager whatever your project is using instead of just npm start?
There was a problem hiding this comment.
We're going to merge this unchanged, our reasoning is that if you are using any other package manager you are likely going to know how to "translate" commands from npm to your chosen package manager 👍
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We aim to teach the use of npm/yarn scripts in addition to bare CLI commands, since in real-world applications, developers may have different configurations specified in package.json scripts than the default commands would provide.
@MehulKChaudhari please review and let me know if you have any feedback!
RFC 831
Since the CLI guides aim to cover the CLI behavior, I did not fully replace things like
ember servewithnpm start, as we may end up doing for the regular ember guides. Instead I added a little bit of prose suggesting when to use the scripts.