Merge pull request #671 from Gaurav0/website-redesign-rfc

remove bourbon-neat

Author: sivakumar-kailasam

app/styles/app.scss

@@ -2,7 +2,6 @@
 @import "normalize";
 @import "bourbon";
 @import "./base/base";
-@import "neat";
 @import "./components/all";
 @import "class";
 @import "ember-power-select";

app/styles/base/_grid-settings.scss

@@ -1,13 +1,6 @@
-@import "neat-helpers"; // or "../neat/neat-helpers" when not in Rails
-// Neat Overrides
-// $column: 90px;
-// $gutter: 30px;
-// $grid-columns: 12;
-// $max-width: 1088px;
-// Neat Breakpoints
 $mobile-portrait-screen: 30em; // 480px
 $medium-screen: 40em; // 640px
 $large-screen: 54em; // 864px
 $medium-screen-up: new-breakpoint(min-width $medium-screen 4);
 $medium-large-screen-up: new-breakpoint(min-width $medium-screen 8);
-$large-screen-up: new-breakpoint(min-width $large-screen 8);
+$large-screen-up: new-breakpoint(min-width $large-screen 8);

app/styles/components/_back-to-top.scss

@@ -5,12 +5,12 @@
   margin-left: 1em;
   text-align: center;
 
-  @include media(max-width 89em) {
+  @media (max-width: 89em) {
     @include size(1.5em);
     overflow: hidden;
   }
 
-  @include media(max-width 78em) {
+  @media (max-width: 78em) {
     height: 0;
   }
 }

app/styles/components/_layout.scss

@@ -1,11 +1,11 @@
 main {
-  @include media($large-screen) {
+  @media screen and (min-width: $large-screen) {
     display: flex;
   }
 }
 
 .container {
-  @include outer-container;
+  margin: 0 auto;
   padding: 0 1em;
   &::after {
   	clear: both;

app/styles/components/_sidebar.scss

@@ -1,6 +1,6 @@
 .sidebar {
 
-  @include media($large-screen-up) {
+  @media (min-width: $large-screen-up) {
     margin-right: 0;
     border-bottom: 0;
     padding: $small-spacing $base-spacing $base-spacing * 1.5;
@@ -46,7 +46,7 @@ label[for="toc-toggle"] {
     border-width: 0 4px 5px 4px;
   }
 
-  @include media($large-screen) {
+  @media screen and (min-width: $large-screen) {
     display: none;
   }
 }
@@ -59,7 +59,7 @@ label[for="toc-toggle"] {
   .toc-toggle:checked ~ & {
     display: block;
   }
-  @include media($large-screen) {
+  @media screen and (min-width: $large-screen) {
     display: block;
 
     // ensure toc-toggle can not cause toc-container to be hidden on large screen

ember-cli-build.js

@@ -13,7 +13,6 @@ module.exports = function(defaults) {
     sassOptions: {
       includePaths: [
         'app/styles',
-        'node_modules/bourbon-neat/app/assets/stylesheets',
         'node_modules/normalize.css'
       ]
     },

package.json

@@ -39,7 +39,6 @@
     "@ember/jquery": "^0.5.2",
     "@ember/optional-features": "^0.6.3",
     "algoliasearch": "^3.32.1",
-    "bourbon-neat": "^1.9.1",
     "broccoli-asset-rev": "^3.0.0",
     "broccoli-funnel": "^2.0.1",
     "broccoli-merge-trees": "^2.0.0",