Update to Ember 4.12.2

.ember-cli

@@ -5,5 +5,11 @@
 
     Setting `disableAnalytics` to true will prevent any data from being sent.
   */
-  "disableAnalytics": false
+  "disableAnalytics": false,
+
+  /**
+    Setting `isTypeScriptProject` to true will force the blueprint generators to generate TypeScript
+    rather than JavaScript by default, when a TypeScript version of a given blueprint is available.
+  */
+  "isTypeScriptProject": false
 }

.eslintignore

@@ -19,4 +19,7 @@
 # ember-try
 /.node_modules.ember-try/
 /bower.json.ember-try
+/npm-shrinkwrap.json.ember-try
 /package.json.ember-try
+/package-lock.json.ember-try
+/yarn.lock.ember-try

.eslintrc.js

@@ -2,12 +2,15 @@
 
 module.exports = {
   root: true,
-  parser: 'babel-eslint',
+  parser: '@babel/eslint-parser',
   parserOptions: {
-    ecmaVersion: 2018,
+    ecmaVersion: 'latest',
     sourceType: 'module',
-    ecmaFeatures: {
-      legacyDecorators: true,
+    requireConfigFile: false,
+    babelOptions: {
+      plugins: [
+        ['@babel/plugin-proposal-decorators', { decoratorsBeforeExport: true }],
+      ],
     },
   },
   plugins: ['ember'],
@@ -30,6 +33,7 @@ module.exports = {
       files: [
         './.eslintrc.js',
         './.prettierrc.js',
+        './.stylelintrc.js',
         './.template-lintrc.js',
         './ember-cli-build.js',
         './testem.js',
@@ -45,16 +49,10 @@ module.exports = {
         browser: false,
         node: true,
       },
-      plugins: ['node'],
-      extends: ['plugin:node/recommended'],
-      rules: {
-        // this can be removed once the following is fixed
-        // https://github.com/mysticatea/eslint-plugin-node/issues/77
-        'node/no-unpublished-require': 'off',
-      },
+      extends: ['plugin:n/recommended'],
     },
     {
-      // Test files:
+      // test files
       files: ['tests/**/*-test.{js,ts}'],
       extends: ['plugin:qunit/recommended'],
       rules: {

.github/workflows/ci.yml

@@ -4,7 +4,11 @@ on:
   push:
     branches:
       - main
-  pull_request:
+  pull_request: {}
+
+concurrency:
+  group: ci-${{ github.head_ref || github.ref }}
+  cancel-in-progress: true
 
 env:
   NODE_VERSION: 20
@@ -18,14 +22,16 @@ jobs:
     timeout-minutes: 3
     steps:
       - name: Check out a copy of the repo
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - uses: mansona/npm-lockfile-version@v1
+        with:
+          version: 3
 
       - name: Use Node.js ${{ env.NODE_VERSION }}
-        uses: actions/setup-node@v2
+        uses: actions/setup-node@v3
         with:
-          cache: 'npm'
+          cache: "npm"
           node-version: ${{ env.NODE_VERSION }}
 
       - name: Install dependencies
@@ -40,12 +46,12 @@ jobs:
     timeout-minutes: 5
     steps:
       - name: Check out a copy of the repo
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: Use Node.js ${{ env.NODE_VERSION }}
-        uses: actions/setup-node@v2
+        uses: actions/setup-node@v3
         with:
-          cache: 'npm'
+          cache: "npm"
           node-version: ${{ env.NODE_VERSION }}
 
       - name: Install dependencies
@@ -64,14 +70,14 @@ jobs:
     timeout-minutes: 5
     steps:
       - name: Check out a copy of the repo
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           ref: ${{ github.event.pull_request.head.sha }}
 
       - name: Use Node.js ${{ env.NODE_VERSION }}
-        uses: actions/setup-node@v2
+        uses: actions/setup-node@v3
         with:
-          cache: 'npm'
+          cache: "npm"
           node-version: ${{ env.NODE_VERSION }}
 
       - name: Install dependencies

.gitignore

@@ -26,6 +26,7 @@ jsconfig.json
 # ember-try
 /.node_modules.ember-try/
 /bower.json.ember-try
+/npm-shrinkwrap.json.ember-try
 /package.json.ember-try
 
 /.lighthouseci/

.prettierignore

@@ -14,8 +14,12 @@
 /coverage/
 !.*
 .eslintcache
+.lint-todo/
 
 # ember-try
 /.node_modules.ember-try/
 /bower.json.ember-try
+/npm-shrinkwrap.json.ember-try
 /package.json.ember-try
+/package-lock.json.ember-try
+/yarn.lock.ember-try

.prettierrc.js

@@ -1,5 +1,12 @@
 'use strict';
 
 module.exports = {
-  singleQuote: true,
+  overrides: [
+    {
+      files: '*.{js,ts}',
+      options: {
+        singleQuote: true,
+      },
+    },
+  ],
 };

.stylelintignore

@@ -0,0 +1,8 @@
+# unconventional files
+/blueprints/*/files/
+
+# compiled output
+/dist/
+
+# addons
+/.node_modules.ember-try/

.stylelintrc.js

@@ -0,0 +1,8 @@
+'use strict';
+
+module.exports = {
+  extends: ['stylelint-config-standard', 'stylelint-prettier/recommended'],
+  rules: {
+    'selector-class-pattern': null,
+  },
+};

.template-lintrc.js

@@ -2,4 +2,9 @@
 
 module.exports = {
   extends: 'recommended',
+  rules: {
+    'no-curly-component-invocation': {
+      allow: ['format-date-time', 'html-safe', 'printf'],
+    },
+  },
 };

README.md

@@ -10,52 +10,52 @@ Components come from [ember-styleguide](https://github.com/ember-learn/ember-sty
 
 You will need the following things properly installed on your computer.
 
-* [Git](https://git-scm.com/)
-* [Node.js](https://nodejs.org/)
-* [Ember CLI](https://ember-cli.com/)
-* [Google Chrome](https://google.com/chrome/)
+- [Git](https://git-scm.com/)
+- [Node.js](https://nodejs.org/) (with npm)
+- [Ember CLI](https://cli.emberjs.com/release/)
+- [Google Chrome](https://google.com/chrome/)
 
 ## Installation
 
-* `git clone <repository-url>` this repository
-* `cd ember-website`
-* `npm install`
+- `git clone <repository-url>` this repository
+- `cd ember-website`
+- `npm install`
 
 ## Running / Development
 
-* `npm start`
-* Visit your app at [http://localhost:4200](http://localhost:4200).
-* Visit your tests at [http://localhost:4200/tests](http://localhost:4200/tests).
+- `npm start`
+- Visit your app at [http://localhost:4200](http://localhost:4200).
+- Visit your tests at [http://localhost:4200/tests](http://localhost:4200/tests).
 
 ### Code Generators
 
 Make use of the many generators for code, try `ember help generate` for more details
 
 ### Running Tests
 
-* `npm test`
-* `npm test --server`
+- `npm test`
+- `npm test --server`
 
 ### Linting
 
-* `npm run lint`
-* `npm run lint:fix`
+- `npm run lint`
+- `npm run lint:fix`
 
 ### Building
 
-* `npm run build` (production)
+- `npm run build` (production)
 
 ### Deploying
 
 The app is continuously deployed to Netlify when a pull request is merged and passes continuous integration.
 
 ## Further Reading / Useful Links
 
-* [ember.js](https://emberjs.com/)
-* [ember-cli](https://ember-cli.com/)
-* Development Browser Extensions
-  * [ember inspector for chrome](https://chrome.google.com/webstore/detail/ember-inspector/bmdblncegkenkacieihfhpjfppoconhi)
-  * [ember inspector for firefox](https://addons.mozilla.org/en-US/firefox/addon/ember-inspector/)
+- [ember.js](https://emberjs.com/)
+- [ember-cli](https://cli.emberjs.com/release/)
+- Development Browser Extensions
+  - [ember inspector for chrome](https://chrome.google.com/webstore/detail/ember-inspector/bmdblncegkenkacieihfhpjfppoconhi)
+  - [ember inspector for firefox](https://addons.mozilla.org/en-US/firefox/addon/ember-inspector/)
 
 ## Sponsors
 

app/components/cta-emberconf.hbs

@@ -9,9 +9,7 @@
           target="_blank"
         >
           <img
-            alt=""
-            role="presentation"
-            src="/images/brand/virtual-emberconf-2022-logo.svg"
+            alt="" src="/images/brand/virtual-emberconf-2022-logo.svg"
           >
         </a>
       </div>

app/components/ember-community-survey/introduction.hbs

@@ -1,5 +1,6 @@
 <div class="bg-dark bg-shape-boxes">
   <div class="container">
+    {{!-- template-lint-disable no-empty-headings --}}
     <h1>
       <img
         alt={{@surveyLogoAlt}}

app/components/index/ember-addons.hbs

@@ -3,7 +3,7 @@
     class="addon-tabs--header"
     role="tablist"
   >
-    {{!-- template-lint-disable "no-down-event-binding" --}}
+    {{!-- template-lint-disable "no-pointer-down-event-binding" --}}
     {{#each this.emberAddons as |emberAddon index|}}
       <Index::EmberAddons::Tab
         @currentTabId={{this.currentTabId}}

app/routes/community/meetups/index.js

@@ -7,4 +7,11 @@ export default class CommunityMeetupsIndexRoute extends Route {
   model() {
     return this.store.findAll('meetup');
   }
+
+  afterModel() {
+    // ember-data runs flushAllPendingFetches using setTimeout, so outside of the Ember runloop.
+    // Under prember this causes `Attempted to call store.adapterFor(), but the store instance has already been destroyed.`
+    // So wait a bit
+    return new Promise((resolve) => setTimeout(resolve, 10));
+  }
 }

app/routes/ember-users.js

@@ -7,4 +7,11 @@ export default class EmberUsersRoute extends Route {
   model() {
     return this.store.findAll('user');
   }
+
+  afterModel() {
+    // ember-data runs flushAllPendingFetches using setTimeout, so outside of the Ember runloop.
+    // Under prember this causes `Attempted to call store.adapterFor(), but the store instance has already been destroyed.`
+    // So wait a bit
+    return new Promise((resolve) => setTimeout(resolve, 10));
+  }
 }

app/routes/learn.js

@@ -7,4 +7,11 @@ export default class LearnRoute extends Route {
   model() {
     return this.store.findAll('showcase');
   }
+
+  afterModel() {
+    // ember-data runs flushAllPendingFetches using setTimeout, so outside of the Ember runloop.
+    // Under prember this causes `Attempted to call store.adapterFor(), but the store instance has already been destroyed.`
+    // So wait a bit
+    return new Promise((resolve) => setTimeout(resolve, 10));
+  }
 }

app/routes/mascots.js

@@ -7,4 +7,11 @@ export default class MascotsRoute extends Route {
   model() {
     return this.store.findAll('tomster');
   }
+
+  afterModel() {
+    // ember-data runs flushAllPendingFetches using setTimeout, so outside of the Ember runloop.
+    // Under prember this causes `Attempted to call store.adapterFor(), but the store instance has already been destroyed.`
+    // So wait a bit
+    return new Promise((resolve) => setTimeout(resolve, 10));
+  }
 }

app/routes/releases.js

@@ -7,4 +7,11 @@ export default class ReleasesRoute extends Route {
   model() {
     return this.store.findAll('project');
   }
+
+  afterModel() {
+    // ember-data runs flushAllPendingFetches using setTimeout, so outside of the Ember runloop.
+    // Under prember this causes `Attempted to call store.adapterFor(), but the store instance has already been destroyed.`
+    // So wait a bit
+    return new Promise((resolve) => setTimeout(resolve, 10));
+  }
 }

app/routes/releases/beta.js

@@ -7,8 +7,15 @@ export default class ReleasesBetaRoute extends Route {
 
   model() {
     return hash({
-      ember: this.store.find('project', 'ember/beta'),
-      emberData: this.store.find('project', 'emberData/beta'),
+      ember: this.store.findRecord('project', 'ember/beta'),
+      emberData: this.store.findRecord('project', 'emberData/beta'),
     });
   }
+
+  afterModel() {
+    // ember-data runs flushAllPendingFetches using setTimeout, so outside of the Ember runloop.
+    // Under prember this causes `Attempted to call store.adapterFor(), but the store instance has already been destroyed.`
+    // So wait a bit
+    return new Promise((resolve) => setTimeout(resolve, 10));
+  }
 }