Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

further modernize core-concepts.svg #1311

Closed
ghost opened this issue Feb 19, 2020 · 3 comments
Closed

further modernize core-concepts.svg #1311

ghost opened this issue Feb 19, 2020 · 3 comments
Labels
help wanted Extra attention is needed Octane

Comments

@ghost
Copy link

ghost commented Feb 19, 2020

Continue the great work in #631.

The core concepts.svg file has some snippets that need updating:
Screen Shot 2020-02-19 at 15 25 48

  • this.model should be @model
  • The route example should use native classes
@locks locks added help wanted Extra attention is needed Octane labels Feb 20, 2020
@rajasegar
Copy link
Contributor

@locks I can pick this up, can you please assign it to me?

@rajasegar rajasegar mentioned this issue Mar 29, 2020
Closed
@rajasegar
Copy link
Contributor

The new file will look like this:
Screenshot_2020-03-29 Anatomy of an Ember App - Getting Started - Ember Guides

@rajasegar
Copy link
Contributor

This can be closed as the PR is already merged
#1393

@locks locks closed this as completed Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed Octane
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Further modernize core-concepts.svg rajasegar/guides-source
2 participants
@locks @rajasegar