Update modifiers related sections to be accurate to what we've been able to do since 3.25 #1829
Conversation
guides/release/components/template-lifecycle-dom-and-modifiers.md
Outdated
Show resolved
Hide resolved
guides/release/components/template-lifecycle-dom-and-modifiers.md
Outdated
Show resolved
Hide resolved
guides/release/components/template-lifecycle-dom-and-modifiers.md
Outdated
Show resolved
Hide resolved
guides/release/components/template-lifecycle-dom-and-modifiers.md
Outdated
Show resolved
Hide resolved
|
I made some small wording changes, added a label to the pre-existing input example, and added |
|
hmm |
| <input {{did-insert this.focus}}> | ||
| </form> | ||
| ``` | ||
| npx ember install ember-modifier |
There was a problem hiding this comment.
whoops, this should be ember-cli
this package: https://www.npmjs.com/package/ember
only prints this message: https://github.com/emberjs/ember/blob/master/index.js
and doesn't actually do anything.
Would be great if ember were configured as a bin that delegated to npx ember-cli
There was a problem hiding this comment.
Oh right, thank you. I will change it to use global ember for now.
| <input {{did-insert this.focus}}> | ||
| </form> | ||
| ``` | ||
| npx ember install ember-modifier |
There was a problem hiding this comment.
| npx ember install ember-modifier | |
| npx ember-cli install ember-modifier |
|
I just found -- I'm gonna address in a separate PR once we resolve this one 🥳 |
This will
releasedocs@ember/render-modifiersas those modifiers were meant for migration from the old paradigms, and not exactly reflective of how the Octane mental model works.Prior to 3.25, all modifiers had to be globally available in
app/modifiers/*-- this is very awkward, and kind of unfortunate from a teaching perspective that we had such a big gap between modifiers being "the thing" and when they can be freely used -- so I'll be ignoring everything prior to 3.25 for these updates.