Tutorial Updates #1832
Merged
Tutorial Updates #1832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
--- Commit: ember-learn/super-rentals-tutorial@ef0fc37 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/ef0fc372ab14d55063011f9bed4c845949d9a1e8/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/ef0fc372ab14d55063011f9bed4c845949d9a1e8/checks
--- Commit: ember-learn/super-rentals-tutorial@ef0fc37 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/ef0fc372ab14d55063011f9bed4c845949d9a1e8/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/ef0fc372ab14d55063011f9bed4c845949d9a1e8/checks
--- Commit: ember-learn/super-rentals-tutorial@ef0fc37 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/ef0fc372ab14d55063011f9bed4c845949d9a1e8/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/ef0fc372ab14d55063011f9bed4c845949d9a1e8/checks
--- Commit: ember-learn/super-rentals-tutorial@ef0fc37 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/ef0fc372ab14d55063011f9bed4c845949d9a1e8/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/ef0fc372ab14d55063011f9bed4c845949d9a1e8/checks
--- Commit: ember-learn/super-rentals-tutorial@aeead18 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/aeead18f118b159de84348eacbf554860f98f13a/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/aeead18f118b159de84348eacbf554860f98f13a/checks
--- Commit: ember-learn/super-rentals-tutorial@aeead18 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/aeead18f118b159de84348eacbf554860f98f13a/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/aeead18f118b159de84348eacbf554860f98f13a/checks
--- Commit: ember-learn/super-rentals-tutorial@aeead18 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/aeead18f118b159de84348eacbf554860f98f13a/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/aeead18f118b159de84348eacbf554860f98f13a/checks
--- Commit: ember-learn/super-rentals-tutorial@aeead18 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/aeead18f118b159de84348eacbf554860f98f13a/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/aeead18f118b159de84348eacbf554860f98f13a/checks
--- Commit: ember-learn/super-rentals-tutorial@aeead18 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/aeead18f118b159de84348eacbf554860f98f13a/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/aeead18f118b159de84348eacbf554860f98f13a/checks
--- Commit: ember-learn/super-rentals-tutorial@aeead18 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/aeead18f118b159de84348eacbf554860f98f13a/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/aeead18f118b159de84348eacbf554860f98f13a/checks
--- Commit: ember-learn/super-rentals-tutorial@aeead18 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/aeead18f118b159de84348eacbf554860f98f13a/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/aeead18f118b159de84348eacbf554860f98f13a/checks
--- Commit: ember-learn/super-rentals-tutorial@aeead18 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/aeead18f118b159de84348eacbf554860f98f13a/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/aeead18f118b159de84348eacbf554860f98f13a/checks
--- Commit: ember-learn/super-rentals-tutorial@aeead18 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/aeead18f118b159de84348eacbf554860f98f13a/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/aeead18f118b159de84348eacbf554860f98f13a/checks
--- Commit: ember-learn/super-rentals-tutorial@aeead18 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/aeead18f118b159de84348eacbf554860f98f13a/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/aeead18f118b159de84348eacbf554860f98f13a/checks
--- Commit: ember-learn/super-rentals-tutorial@aeead18 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/aeead18f118b159de84348eacbf554860f98f13a/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/aeead18f118b159de84348eacbf554860f98f13a/checks
--- Commit: ember-learn/super-rentals-tutorial@aeead18 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/aeead18f118b159de84348eacbf554860f98f13a/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/aeead18f118b159de84348eacbf554860f98f13a/checks
--- Commit: ember-learn/super-rentals-tutorial@aeead18 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/aeead18f118b159de84348eacbf554860f98f13a/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/aeead18f118b159de84348eacbf554860f98f13a/checks
--- Commit: ember-learn/super-rentals-tutorial@aeead18 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/aeead18f118b159de84348eacbf554860f98f13a/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/aeead18f118b159de84348eacbf554860f98f13a/checks
--- Commit: ember-learn/super-rentals-tutorial@aeead18 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/aeead18f118b159de84348eacbf554860f98f13a/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/aeead18f118b159de84348eacbf554860f98f13a/checks
--- Commit: ember-learn/super-rentals-tutorial@aeead18 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/aeead18f118b159de84348eacbf554860f98f13a/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/aeead18f118b159de84348eacbf554860f98f13a/checks
--- Commit: ember-learn/super-rentals-tutorial@aeead18 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/aeead18f118b159de84348eacbf554860f98f13a/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/aeead18f118b159de84348eacbf554860f98f13a/checks
--- Commit: ember-learn/super-rentals-tutorial@aeead18 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/aeead18f118b159de84348eacbf554860f98f13a/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/aeead18f118b159de84348eacbf554860f98f13a/checks
--- Commit: ember-learn/super-rentals-tutorial@aeead18 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/aeead18f118b159de84348eacbf554860f98f13a/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/aeead18f118b159de84348eacbf554860f98f13a/checks
bit trickier --- Commit: ember-learn/super-rentals-tutorial@d557659 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/d5576591e60b121a02276915a8af95fc84ce0eab/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/d5576591e60b121a02276915a8af95fc84ce0eab/checks
--- Commit: ember-learn/super-rentals-tutorial@d557659 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/d5576591e60b121a02276915a8af95fc84ce0eab/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/d5576591e60b121a02276915a8af95fc84ce0eab/checks
--- Commit: ember-learn/super-rentals-tutorial@d557659 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/d5576591e60b121a02276915a8af95fc84ce0eab/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/d5576591e60b121a02276915a8af95fc84ce0eab/checks
--- Commit: ember-learn/super-rentals-tutorial@d557659 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/d5576591e60b121a02276915a8af95fc84ce0eab/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/d5576591e60b121a02276915a8af95fc84ce0eab/checks
--- Commit: ember-learn/super-rentals-tutorial@d557659 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/d5576591e60b121a02276915a8af95fc84ce0eab/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/d5576591e60b121a02276915a8af95fc84ce0eab/checks
--- Commit: ember-learn/super-rentals-tutorial@67a50e7 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/67a50e76b57735f2018ecc8a3408a3519c60d791/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/67a50e76b57735f2018ecc8a3408a3519c60d791/checks
--- Commit: ember-learn/super-rentals-tutorial@67a50e7 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/67a50e76b57735f2018ecc8a3408a3519c60d791/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/67a50e76b57735f2018ecc8a3408a3519c60d791/checks
--- Commit: ember-learn/super-rentals-tutorial@67a50e7 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/67a50e76b57735f2018ecc8a3408a3519c60d791/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/67a50e76b57735f2018ecc8a3408a3519c60d791/checks
--- Commit: ember-learn/super-rentals-tutorial@67a50e7 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/67a50e76b57735f2018ecc8a3408a3519c60d791/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/67a50e76b57735f2018ecc8a3408a3519c60d791/checks
--- Commit: ember-learn/super-rentals-tutorial@67a50e7 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/67a50e76b57735f2018ecc8a3408a3519c60d791/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/67a50e76b57735f2018ecc8a3408a3519c60d791/checks
--- Commit: ember-learn/super-rentals-tutorial@67a50e7 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/67a50e76b57735f2018ecc8a3408a3519c60d791/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/67a50e76b57735f2018ecc8a3408a3519c60d791/checks
--- Commit: ember-learn/super-rentals-tutorial@67a50e7 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/67a50e76b57735f2018ecc8a3408a3519c60d791/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/67a50e76b57735f2018ecc8a3408a3519c60d791/checks
--- Commit: ember-learn/super-rentals-tutorial@67a50e7 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/67a50e76b57735f2018ecc8a3408a3519c60d791/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/67a50e76b57735f2018ecc8a3408a3519c60d791/checks
|
Hi @ember-learn/learning-core-team, we have two years of improvements to the tutorials that haven't been published because this PR is lingering. How can we fix the process here? |
|
When I wrote the message in the automated PR, I probably made it sound too scary?? It’s not actually a very complicated process if you understand what’s up. The original sins are:
So the combination of those two make it slightly less straightforward than just clicking the merge button, but not that much more As far as how to merge this PR, the key is we don’t want to merge in the image diffs at all if they aren’t meaningfully different, and if we do want to merge we want to make sure to merge only those we want to keep and squash, so that we are only adding the minimum amount of binary bloat to git. Mechanically, that usually means to pull the branch, discard the unwanted diffs by checking out the version from main, then either squash locally or using the squash to merge button. It takes a few minutes on a computer once you are fluent with git. As far as how we can fix this process wise:
All of them are perfectly doable, I was going to do 3 but didn’t get around to do it. It’s not ideal, but given that we didn’t intentionally update the tutorial content that often it may be fine in practice. Happy to pair on either doing the merge or that tweak to the automation. Ideally I don’t just fix this myself and no one learns to do it |
--- Commit: ember-learn/super-rentals-tutorial@67a50e7 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/67a50e76b57735f2018ecc8a3408a3519c60d791/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/67a50e76b57735f2018ecc8a3408a3519c60d791/checks
--- Commit: ember-learn/super-rentals-tutorial@67a50e7 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/67a50e76b57735f2018ecc8a3408a3519c60d791/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/67a50e76b57735f2018ecc8a3408a3519c60d791/checks
--- Commit: ember-learn/super-rentals-tutorial@67a50e7 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/67a50e76b57735f2018ecc8a3408a3519c60d791/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/67a50e76b57735f2018ecc8a3408a3519c60d791/checks
--- Commit: ember-learn/super-rentals-tutorial@67a50e7 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/67a50e76b57735f2018ecc8a3408a3519c60d791/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/67a50e76b57735f2018ecc8a3408a3519c60d791/checks
--- Commit: ember-learn/super-rentals-tutorial@67a50e7 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/67a50e76b57735f2018ecc8a3408a3519c60d791/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/67a50e76b57735f2018ecc8a3408a3519c60d791/checks
mansona
requested changes
Feb 10, 2024
--- Commit: ember-learn/super-rentals-tutorial@67a50e7 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/67a50e76b57735f2018ecc8a3408a3519c60d791/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/67a50e76b57735f2018ecc8a3408a3519c60d791/checks
--- Commit: ember-learn/super-rentals-tutorial@67a50e7 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/67a50e76b57735f2018ecc8a3408a3519c60d791/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/67a50e76b57735f2018ecc8a3408a3519c60d791/checks
--- Commit: ember-learn/super-rentals-tutorial@67a50e7 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/67a50e76b57735f2018ecc8a3408a3519c60d791/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/67a50e76b57735f2018ecc8a3408a3519c60d791/checks
--- Commit: ember-learn/super-rentals-tutorial@67a50e7 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/67a50e76b57735f2018ecc8a3408a3519c60d791/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/67a50e76b57735f2018ecc8a3408a3519c60d791/checks
--- Commit: ember-learn/super-rentals-tutorial@67a50e7 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/67a50e76b57735f2018ecc8a3408a3519c60d791/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/67a50e76b57735f2018ecc8a3408a3519c60d791/checks
--- Commit: ember-learn/super-rentals-tutorial@67a50e7 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/67a50e76b57735f2018ecc8a3408a3519c60d791/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/67a50e76b57735f2018ecc8a3408a3519c60d791/checks
--- Commit: ember-learn/super-rentals-tutorial@67a50e7 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/67a50e76b57735f2018ecc8a3408a3519c60d791/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/67a50e76b57735f2018ecc8a3408a3519c60d791/checks
--- Commit: ember-learn/super-rentals-tutorial@67a50e7 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/67a50e76b57735f2018ecc8a3408a3519c60d791/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/67a50e76b57735f2018ecc8a3408a3519c60d791/checks
--- Commit: ember-learn/super-rentals-tutorial@67a50e7 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/67a50e76b57735f2018ecc8a3408a3519c60d791/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/67a50e76b57735f2018ecc8a3408a3519c60d791/checks
--- Commit: ember-learn/super-rentals-tutorial@67a50e7 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/67a50e76b57735f2018ecc8a3408a3519c60d791/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/67a50e76b57735f2018ecc8a3408a3519c60d791/checks
mansona
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
We have fixed all the previous versions of the tutorial with #2000 and we need to now merge this PR to fix the current release version. This will tide us over until the next release (6 weeks from now i.e. 5.8.0) to properly integrate the tutorial updates into our release process 👍
|
Usually I would squash merge this massive PR, but our process for fixing the previous versions of the tutorial made good use of the history in this branch so I am going to create a merge commit to retain history 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to let you know there are new content available for the tutorial!
If these changes look good to you, it is recommended that you merge the PR using the Squash and merge feature.
If there are any issues with the content here, do not edit these files directly – the original source lives in the super-rentals-tutorial repo.
Feel free to hold off on merging this PR and file an issue/PR in the upstream repo. After fixing the issues there, the upstream CI job will push the changes to this pull request branch, automatically, so you should see the changes reflected in this PR shortly after.
That being said, it's totally okay to push other changes to the
super-rentals-tutorialbranch manually, like making changes to the TOC or adding words to the dictionary. Just don't edit the markdown files themselves, since any changes you make will be wiped out by the next upstream CI job.You can rebase the branch and force-push, or even delete it! The CI job clones the branch fresh on each build, and re-creates it from the master branch if needed, so there shouldn't be any issues with conflicts and such.