From 5c9f1dd4e1761b62938ba9ffc3cd45e50a03e2a1 Mon Sep 17 00:00:00 2001 From: Eli Flanagan Date: Tue, 18 Jun 2019 13:28:18 -0400 Subject: [PATCH 1/2] remove documented use of sinceToken > the TL;DR here is that the adapter APIs (which are public) still have a "slot" for sinceToken per runspired --- packages/adapter/addon/adapter.js | 6 ++---- packages/adapter/addon/rest.js | 1 - 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/packages/adapter/addon/adapter.js b/packages/adapter/addon/adapter.js index d4fad239d66..87c35c429ad 100644 --- a/packages/adapter/addon/adapter.js +++ b/packages/adapter/addon/adapter.js @@ -130,11 +130,10 @@ export default EmberObject.extend({ import $ from 'jquery'; export default DS.Adapter.extend({ - findAll(store, type, sinceToken) { - let query = { since: sinceToken }; + findAll(store, type) { return new RSVP.Promise(function(resolve, reject) { - $.getJSON(`/${type.modelName}`, query).then(function(data) { + $.getJSON(`/${type.modelName}`).then(function(data) { resolve(data); }, function(jqXHR) { reject(jqXHR); @@ -147,7 +146,6 @@ export default EmberObject.extend({ @method findAll @param {DS.Store} store @param {DS.Model} type - @param {String} sinceToken @param {DS.SnapshotRecordArray} snapshotRecordArray @return {Promise} promise */ diff --git a/packages/adapter/addon/rest.js b/packages/adapter/addon/rest.js index 53f7f9afc03..6a218c96a86 100644 --- a/packages/adapter/addon/rest.js +++ b/packages/adapter/addon/rest.js @@ -516,7 +516,6 @@ const RESTAdapter = Adapter.extend(BuildURLMixin, { @method findAll @param {DS.Store} store @param {DS.Model} type - @param {String} sinceToken @param {DS.SnapshotRecordArray} snapshotRecordArray @return {Promise} promise */ From 5ae614774e7146952c2e5a47a7a4a071c8b95690 Mon Sep 17 00:00:00 2001 From: Eli Flanagan Date: Wed, 19 Jun 2019 17:10:21 -0400 Subject: [PATCH 2/2] address feedback --- packages/adapter/addon/adapter.js | 1 + packages/adapter/addon/rest.js | 1 + 2 files changed, 2 insertions(+) diff --git a/packages/adapter/addon/adapter.js b/packages/adapter/addon/adapter.js index 87c35c429ad..df53703fde7 100644 --- a/packages/adapter/addon/adapter.js +++ b/packages/adapter/addon/adapter.js @@ -146,6 +146,7 @@ export default EmberObject.extend({ @method findAll @param {DS.Store} store @param {DS.Model} type + @param {undefined} neverSet a value is never provided to this argument @param {DS.SnapshotRecordArray} snapshotRecordArray @return {Promise} promise */ diff --git a/packages/adapter/addon/rest.js b/packages/adapter/addon/rest.js index 6a218c96a86..b84f22ac8e0 100644 --- a/packages/adapter/addon/rest.js +++ b/packages/adapter/addon/rest.js @@ -516,6 +516,7 @@ const RESTAdapter = Adapter.extend(BuildURLMixin, { @method findAll @param {DS.Store} store @param {DS.Model} type + @param {undefined} neverSet a value is never provided to this argument @param {DS.SnapshotRecordArray} snapshotRecordArray @return {Promise} promise */