From 109aac1691eb06452f731850fcd2a0bb59de3933 Mon Sep 17 00:00:00 2001
From: Cyrille David <dcyriller@users.noreply.github.com>
Date: Wed, 28 Aug 2019 21:41:44 +0200
Subject: [PATCH] fix: Strip Symbol from production builds (#6389)

* Add a Symbol-like symbol (thank you glimmer-vm)

This is similar to what is implemented here:
https://github.com/glimmerjs/glimmer-vm/blob/72718d0d6ebb2614ec984f51435a44830d410e4c/packages/%40glimmer/reference/lib/validators.ts

* Replace `Symbol`s that may be iterable by `symbol`s

These occurences of Symbol might be replaced by this `symbol`, similar
but different in the sense it is iterable.
---
 .../addon/-private/system/fetch-manager.ts    |  3 ++-
 .../addon/-private/system/request-cache.ts    |  5 +++--
 .../-private/ts-interfaces/utils/brand.ts     |  5 ++++-
 .../-private/ts-interfaces/utils/symbol.ts    | 19 +++++++++++++++++++
 4 files changed, 28 insertions(+), 4 deletions(-)
 create mode 100644 packages/store/addon/-private/ts-interfaces/utils/symbol.ts

diff --git a/packages/store/addon/-private/system/fetch-manager.ts b/packages/store/addon/-private/system/fetch-manager.ts
index 3956811f639..7551acc481a 100644
--- a/packages/store/addon/-private/system/fetch-manager.ts
+++ b/packages/store/addon/-private/system/fetch-manager.ts
@@ -15,6 +15,7 @@ import RequestCache from './request-cache';
 import { CollectionResourceDocument, SingleResourceDocument } from '../ts-interfaces/ember-data-json-api';
 import { RecordIdentifier } from '../ts-interfaces/identifier';
 import { FindRecordQuery, SaveRecordMutation, Request } from '../ts-interfaces/fetch-manager';
+import { symbol } from '../ts-interfaces/utils/symbol';
 import Store from './store';
 import recordDataFor from './record-data-for';
 
@@ -27,7 +28,7 @@ function payloadIsNotBlank(adapterPayload): boolean {
 }
 
 const emberRun = emberRunLoop.backburner;
-export const SaveOp = Symbol('SaveOp');
+export const SaveOp: unique symbol = symbol('SaveOp');
 
 interface PendingFetchItem {
   identifier: RecordIdentifier;
diff --git a/packages/store/addon/-private/system/request-cache.ts b/packages/store/addon/-private/system/request-cache.ts
index 215c85e54db..ae690f73263 100644
--- a/packages/store/addon/-private/system/request-cache.ts
+++ b/packages/store/addon/-private/system/request-cache.ts
@@ -7,11 +7,12 @@ import {
   Operation,
   RequestStateEnum,
 } from '../ts-interfaces/fetch-manager';
+import { symbol } from '../ts-interfaces/utils/symbol';
 
 import { _findHasMany, _findBelongsTo, _findAll, _query, _queryRecord } from './store/finders';
 
-const Touching = Symbol('touching');
-export const RequestPromise = Symbol('promise');
+export const Touching: unique symbol = symbol('touching');
+export const RequestPromise: unique symbol = symbol('promise');
 
 export interface InternalRequest extends RequestState {
   [Touching]: RecordIdentifier[];
diff --git a/packages/store/addon/-private/ts-interfaces/utils/brand.ts b/packages/store/addon/-private/ts-interfaces/utils/brand.ts
index bec27cc574d..bfd626a8909 100644
--- a/packages/store/addon/-private/ts-interfaces/utils/brand.ts
+++ b/packages/store/addon/-private/ts-interfaces/utils/brand.ts
@@ -1,3 +1,5 @@
+import { symbol } from './symbol';
+
 /**
   @module @ember-data/store
 */
@@ -14,4 +16,5 @@
  *
  * @internal
  */
-export const BRAND_SYMBOL = Symbol(`DEBUG-ts-brand`);
+
+export const BRAND_SYMBOL: unique symbol = symbol('DEBUG-ts-brand');
diff --git a/packages/store/addon/-private/ts-interfaces/utils/symbol.ts b/packages/store/addon/-private/ts-interfaces/utils/symbol.ts
new file mode 100644
index 00000000000..ae8b0acb448
--- /dev/null
+++ b/packages/store/addon/-private/ts-interfaces/utils/symbol.ts
@@ -0,0 +1,19 @@
+/**
+  @module @ember-data/store
+*/
+
+/**
+ * This symbol provides a Symbol replacement for browsers that do not have it
+ * (eg. IE 11).
+ *
+ * The replacement is different from the native Symbol in some ways. It is a
+ * function that produces an output:
+ * - iterable;
+ * - that is a string, not a symbol.
+ *
+ * @internal
+ */
+export const symbol =
+  typeof Symbol !== 'undefined'
+    ? Symbol
+    : (key: string) => `__${key}${Math.floor(Math.random() * Date.now())}__` as any;