Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to run all tests in a fresh checkout of master #148

Closed
jbryson3 opened this issue Apr 20, 2017 · 6 comments
Closed

Unable to run all tests in a fresh checkout of master #148

jbryson3 opened this issue Apr 20, 2017 · 6 comments

Comments

@jbryson3
Copy link

It run the jsHint tests but not much else
Terminal output has:

'require' is imported by tmp/rollup-cache_path-GK58QtLK.tmp/ember-test-helpers/build-registry.js, but could not be resolved – treating it as an external dependency
'require' is imported by tmp/rollup-cache_path-GK58QtLK.tmp/ember-test-helpers/test-module-for-model.js, but could not be resolved – treating it as an external dependency

Console output has:

loader.js:58 Uncaught Error: Could not find module require
at requireModule (loader.js:58)
at reify (loader.js:41)
at requireModule (loader.js:69)
at reify (loader.js:41)
at requireModule (loader.js:69)
at reify (loader.js:41)
at requireModule (loader.js:69)
at TestLoader.loadModules (test-loader.js:16)
at Function.TestLoader.load (test-loader.js:23)
at test-loader.js:26

All the tests start running again if I use ember-test-helpers: 0.6.2
Seems to be trouble with ember-test-helpers: 0.6.3

@rwjblue
Copy link
Member

rwjblue commented Apr 20, 2017

#147 should have fixed this, and CI was green when it landed...

@Turbo87
Copy link
Member

Turbo87 commented Apr 21, 2017

@rwjblue we don't have any jshint tests anymore in this repository. it seems like @jbryson3 might be talking about his own test suite.

@rwjblue
Copy link
Member

rwjblue commented Apr 21, 2017

Ah, I see.

I think a demo reproduction would be super helpful here...

@jbryson3
Copy link
Author

@rwjblue #147 was not merged into Master. I didn't realize that v0.11.x was the active branch that I should be using.

@Turbo87 I apologize, I meant to say ESLint tests, not jshint. I was attempting to run the test suite of ember-mocha.

I was attempting to run the suite of tests from the master branch that last had a commit in January (f575810)

Tests are working fine on the v0.11.x branch

@rwjblue
Copy link
Member

rwjblue commented Apr 21, 2017

AHA! I didn't realize that commit wasn't on master though. I'm guessing that @Turbo87 just needs to merge that fix up into master?

@Turbo87
Copy link
Member

Turbo87 commented Apr 21, 2017

I'm guessing that @Turbo87 just needs to merge that fix up into master?

yeah, that will need to happen soonish...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants