chaijs 1.10 allows to write lint-friendly tests #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanneswuerbach
force-pushed
the
no-expr
branch
from
d1cba18
to
2f75240
Compare
| }); | ||
| }); | ||
| expect(pendingSpec).to.be.defined; |
There was a problem hiding this comment.
This was actually never doing the intended verification of pendingSpec. defined is actually not a defined chai assertion and so this was testing for undefined. The new function syntax prevents those errors.
|
chaijs/chai#297 was reverted in chaijs/chai#306, so I don't think we can go with these changes.... |
johanneswuerbach
added a commit
to johanneswuerbach/ember-mocha
that referenced
this pull request
Feb 7, 2015
Extracted from emberjs#13
Merged
|
ok, I extracted the test fix #17 and will close this until chai released a new version, which might support this or not. |
|
Definitely looking forward to chai being more lint-friendly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details chaijs/chai#297