From c6edaa3982510527b6f435641b3c9ef8d50ece1a Mon Sep 17 00:00:00 2001 From: Peter Wagenet Date: Tue, 6 Dec 2022 09:22:47 -0800 Subject: [PATCH 1/2] Build types when checking --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 16ad88481ce..f9d7ba444cf 100644 --- a/package.json +++ b/package.json @@ -51,7 +51,7 @@ "test:node": "qunit tests/node/**/*-test.js", "test:browserstack": "node bin/run-browserstack-tests.js", "type-check:internals": "tsc --noEmit", - "type-check:types": "tsc --noEmit --project type-tests", + "type-check:types": "yarn build:types && tsc --noEmit --project type-tests", "type-check": "npm-run-all type-check:*" }, "dependencies": { From 7073f8ca47ad7690a835d4ca3602c46726601a54 Mon Sep 17 00:00:00 2001 From: Peter Wagenet Date: Tue, 6 Dec 2022 09:53:35 -0800 Subject: [PATCH 2/2] Remove unnecessary step from CI --- .github/workflows/ci.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d240cd0300e..6ddf4e2907e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -43,8 +43,6 @@ jobs: cache: yarn - name: install dependencies run: yarn install --frozen-lockfile --non-interactive - - name: build stable type definitions - run: yarn build:types - name: Check published types run: yarn type-check:types