Merge pull request #20919 from wagenet/kill-more-mixins

[Next] Kill Action Mixins

Author: wagenet

broccoli/amd-compat-entrypoints/ember.debug.js

@@ -56,12 +56,6 @@ d('@ember/-internals/runtime/index', emberinternalsRuntimeIndex);
 import * as emberinternalsRuntimeLibExtRsvp from '@ember/-internals/runtime/lib/ext/rsvp';
 d('@ember/-internals/runtime/lib/ext/rsvp', emberinternalsRuntimeLibExtRsvp);
 
-import * as emberinternalsRuntimeLibMixinsActionHandler from '@ember/-internals/runtime/lib/mixins/action_handler';
-d(
-  '@ember/-internals/runtime/lib/mixins/action_handler',
-  emberinternalsRuntimeLibMixinsActionHandler
-);
-
 import * as emberinternalsRuntimeLibMixinsContainerProxy from '@ember/-internals/runtime/lib/mixins/container_proxy';
 d(
   '@ember/-internals/runtime/lib/mixins/container_proxy',
@@ -74,12 +68,6 @@ d(
   emberinternalsRuntimeLibMixinsRegistryProxy
 );
 
-import * as emberinternalsRuntimeLibMixinsTargetActionSupport from '@ember/-internals/runtime/lib/mixins/target_action_support';
-d(
-  '@ember/-internals/runtime/lib/mixins/target_action_support',
-  emberinternalsRuntimeLibMixinsTargetActionSupport
-);
-
 import * as emberinternalsStringIndex from '@ember/-internals/string/index';
 d('@ember/-internals/string/index', emberinternalsStringIndex);
 
@@ -104,9 +92,6 @@ d(
 import * as emberinternalsViewsLibComponentLookup from '@ember/-internals/views/lib/component_lookup';
 d('@ember/-internals/views/lib/component_lookup', emberinternalsViewsLibComponentLookup);
 
-import * as emberinternalsViewsLibMixinsActionSupport from '@ember/-internals/views/lib/mixins/action_support';
-d('@ember/-internals/views/lib/mixins/action_support', emberinternalsViewsLibMixinsActionSupport);
-
 import * as emberinternalsViewsLibSystemActionManager from '@ember/-internals/views/lib/system/action_manager';
 d('@ember/-internals/views/lib/system/action_manager', emberinternalsViewsLibSystemActionManager);
 

package.json

@@ -203,18 +203,15 @@
       "@ember/-internals/routing/index.js": "ember-source/@ember/-internals/routing/index.js",
       "@ember/-internals/runtime/index.js": "ember-source/@ember/-internals/runtime/index.js",
       "@ember/-internals/runtime/lib/ext/rsvp.js": "ember-source/@ember/-internals/runtime/lib/ext/rsvp.js",
-      "@ember/-internals/runtime/lib/mixins/action_handler.js": "ember-source/@ember/-internals/runtime/lib/mixins/action_handler.js",
       "@ember/-internals/runtime/lib/mixins/container_proxy.js": "ember-source/@ember/-internals/runtime/lib/mixins/container_proxy.js",
       "@ember/-internals/runtime/lib/mixins/registry_proxy.js": "ember-source/@ember/-internals/runtime/lib/mixins/registry_proxy.js",
-      "@ember/-internals/runtime/lib/mixins/target_action_support.js": "ember-source/@ember/-internals/runtime/lib/mixins/target_action_support.js",
       "@ember/-internals/string/index.js": "ember-source/@ember/-internals/string/index.js",
       "@ember/-internals/utility-types/index.js": "ember-source/@ember/-internals/utility-types/index.js",
       "@ember/-internals/utils/index.js": "ember-source/@ember/-internals/utils/index.js",
       "@ember/-internals/views/index.js": "ember-source/@ember/-internals/views/index.js",
       "@ember/-internals/views/lib/compat/attrs.js": "ember-source/@ember/-internals/views/lib/compat/attrs.js",
       "@ember/-internals/views/lib/compat/fallback-view-registry.js": "ember-source/@ember/-internals/views/lib/compat/fallback-view-registry.js",
       "@ember/-internals/views/lib/component_lookup.js": "ember-source/@ember/-internals/views/lib/component_lookup.js",
-      "@ember/-internals/views/lib/mixins/action_support.js": "ember-source/@ember/-internals/views/lib/mixins/action_support.js",
       "@ember/-internals/views/lib/system/action_manager.js": "ember-source/@ember/-internals/views/lib/system/action_manager.js",
       "@ember/-internals/views/lib/system/event_dispatcher.js": "ember-source/@ember/-internals/views/lib/system/event_dispatcher.js",
       "@ember/-internals/views/lib/system/utils.js": "ember-source/@ember/-internals/views/lib/system/utils.js",

packages/@ember/-internals/glimmer/lib/component-managers/curly.ts

@@ -239,7 +239,7 @@ export default class CurlyComponentManager
   /*
    * This hook is responsible for actually instantiating the component instance.
    * It also is where we perform additional bookkeeping to support legacy
-   * features like exposed by view mixins like ChildViewSupport, ActionSupport,
+   * features like exposed by view mixins like ChildViewSupport,
    * etc.
    */
   create(

packages/@ember/-internals/glimmer/lib/component.ts

@@ -7,10 +7,8 @@ import {
 } from '@ember/-internals/metal';
 import type { PropertyDidChange } from '@ember/-internals/metal/lib/property_events';
 import { getOwner } from '@ember/-internals/owner';
-import { TargetActionSupport } from '@ember/-internals/runtime';
 import type { ViewStates } from '@ember/-internals/views';
 import {
-  ActionSupport,
   addChildView,
   CoreView,
   EventDispatcher,
@@ -789,22 +787,14 @@ declare const SIGNATURE: unique symbol;
 
   @class Component
   @extends Ember.CoreView
-  @uses Ember.TargetActionSupport
-  @uses Ember.ActionSupport
   @public
 */
 // This type param is used in the class, so must appear here.
 // eslint-disable-next-line @typescript-eslint/no-unused-vars
-interface Component<S = unknown>
-  extends CoreView,
-    TargetActionSupport,
-    ActionSupport,
-    ComponentMethods {}
+interface Component<S = unknown> extends CoreView, ComponentMethods {}
 
 class Component<S = unknown>
   extends CoreView.extend(
-    TargetActionSupport,
-    ActionSupport,
     {
       // These need to be overridable via extend/create but should still
       // have a default. Defining them here is the best way to achieve that.

packages/@ember/-internals/glimmer/tests/integration/components/target-action-test.js

@@ -1,7 +1,5 @@
 export { default as RegistryProxyMixin } from './lib/mixins/registry_proxy';
 export { default as ContainerProxyMixin } from './lib/mixins/container_proxy';
-export { default as ActionHandler } from './lib/mixins/action_handler';
 export { default as MutableEnumerable } from '@ember/enumerable/mutable';
-export { default as TargetActionSupport } from './lib/mixins/target_action_support';
 
 export { default as RSVP, onerrorDefault } from './lib/ext/rsvp'; // just for side effect of extending Ember.RSVP