Router supports didTransition, but not willTransition

[asakusuma]

Currently the Router supports the Route didTransition event:

App.Router = Ember.Router.extend({
      myAfterTransitionHook: function() {
            //stuff       
      }.on('didTransition')
});

However, the Router does not support the Route willTransition event. In other words, you can't do this:

App.Router = Ember.Router.extend({
      myBeforeTransitionHook: function() {
            //stuff       
      }.on('willTransition')
});

Is there a specific reason for not supporting willTransition? If not, I'd be happy to submit a PR. I'd like to be able to save/record state right before a transition happens, on a general level, not specific to an individual route. Something along the lines of intercepting any time {{link-to}} happens.

[chadhietala]

@asakusuma I think you might be able to achieve what you want using the "activate" and "deactivate" hooks.

#5569
Blog Post

[asakusuma]

@chadhietala just tried activate/deactivate on Ember 1.9.1, works on Route, as expected, but not on a Router.

Not sure if there's more router code distributed elsewhere, but in router.js, there appears to be a line triggering the 'didTransition' event, but I don't see any other events like deactivate or willTransition.

[jayphelps]

It would need to be added to tildeio/router.js since that's where the actual didTransition is originally invoked on the router.

Seems fairly trivial, I'll gladly PR (or you can) if core is OK with the addition. Seems like it should exist for parity.

[asakusuma]

@jayphelps thanks, I'll wait for an OK from core and then open a PR.

[stefanpenner]

seems very reasonable, lets check with mr router to be sure.

[machty]

@asakusuma Seems like a good idea to add to router.js/Ember router. 👍 for a PR

[asakusuma]

Awesome, I'll submit a PR shortly

[asakusuma]

Here's teh tildeio/router PR: tildeio/router.js#144

Once that's in, I'll open another PR in Ember.js

[chadhietala]

@asakusuma Looks like tildeio/router.js#144 was merged.