Skip to content

[BUGFIX beta] layout now supports computed property #14390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rwjblue merged 1 commit into from
Sep 30, 2016
Merged

[BUGFIX beta] layout now supports computed property #14390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ember-glimmer/lib/syntax/curly-component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ class CurlyComponentManager {
}

templateFor(component, env) {
let Template = component.layout;
let Template = get(component, 'layout');
let owner = component[OWNER];
if (Template) {
return env.getTemplate(Template, owner);
Expand Down
19 changes: 19 additions & 0 deletions packages/ember-glimmer/tests/integration/components/curly-components-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,25 @@ moduleFor('Components test: curly components', class extends RenderingTest {
this.assertText('so much layout wat hey');
}

['@test layout supports computed property']() {
let FooBarComponent = Component.extend({
elementId: 'blahzorz',
layout: computed(function () {
return compile('so much layout wat {{lulz}}');
}),
init() {
this._super(...arguments);
this.lulz = 'heyo';
}
});

this.registerComponent('foo-bar', { ComponentClass: FooBarComponent });

this.render('{{foo-bar}}');

this.assertText('so much layout wat heyo');
}

['@test passing undefined elementId results in a default elementId'](assert) {
let FooBarComponent = Component.extend({
tagName: 'h1'
Expand Down