Deprecate Component#isVisible #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, thanks for putting this together! This fixes a few small typos, and rephrases "attribute" to "property", as the first is commonly used when creating HTML nodes. See https://stackoverflow.com/questions/6003819/what-is-the-difference-between-properties-and-attributes-in-html
simonihmig
reviewed
Apr 3, 2018
| What would be the suggested way of hiding components from the DOM in Ember as | ||
| there are a few options to choose from? | ||
|
|
||
| When will support for the deprecated property end? |
There was a problem hiding this comment.
It is public, so according to SemVer this should be 4.0
Parrryy
force-pushed
the
master.deprecate-is-visible
branch
from
f679254 to
cc52c4a
Compare
Updated Support
Parrryy
force-pushed
the
master.deprecate-is-visible
branch
from
cc52c4a to
e9ad244
Compare
|
As to when the support will end, I think since isVisible is public it will have to be 4.0 |
|
New Draft Updated the support ending section. |
Serabe
reviewed
Apr 18, 2018
| such as `<div hidden={{boolean}}></div>`(hidden is valid for all elements | ||
| and is semantically correct) or wrapping the component in a template | ||
| conditional `{{#if}}`statement which do not interfere with | ||
| the `StyleBindingReference`. Components `classNames` an `classNameBindings` |
rwjblue
changed the title
|
If anyone is curious about the accessibility concerns for display:none; - https://webaim.org/techniques/css/invisiblecontent/ |
|
This RFC came up at the Ember.js Core Team meeting today, and we have decided to move it forward into final comment period... |
|
We reviewed this again at todays core team meeting, and are all still in favor. Thanks to everyone who participated! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered