Update addon dependencies #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing test here should get fixed by
I think we should do the first at the minimum, but still can decide to also do the second if that seems better overall!? cc @patricklx |
simonihmig
force-pushed
the
update-deps
branch
from
c77c952 to
defb13c
Compare
Updating to addon-dev@6.0.1 fixed that issue. Remaining failing tests here are unrelated, failing everywhere else as well! 😕 |
SergeAstapov
approved these changes
Nov 10, 2024
simonihmig
force-pushed
the
update-deps
branch
from
defb13c to
68cb6d6
Compare
NullVoxPopuli
approved these changes
Nov 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.