Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Two widgets had hard-coded corner radius instead of using the WidgetVisuals value.
Solution
Remove the hard-coded values and use the style instead.
Context
I tried to make a style with non rounded corners and noticed that certain widgets kept their roundness.
It turned out that there were two widgets with hard-coded values. This PR uses the value from the
WidgetVisual
which seems like the right thing to do. Maybe there's a reason not to but it seems to fix my problem with no apparent downsides.Check.sh Issues
Note that I tried running
check.sh
but it fails to compile 'speech-dispatcher'. Most likely because the version on libspeechd I installed on my machine (latest on Arch linux) is too new and doesn't work with the existing crate.