Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hard-coded corner radii #1119

Merged
merged 2 commits into from
Jan 16, 2022
Merged

Conversation

juancampa
Copy link
Contributor

@juancampa juancampa commented Jan 16, 2022

Problem

Two widgets had hard-coded corner radius instead of using the WidgetVisuals value.

Solution

Remove the hard-coded values and use the style instead.

Context

I tried to make a style with non rounded corners and noticed that certain widgets kept their roundness.

It turned out that there were two widgets with hard-coded values. This PR uses the value from the WidgetVisual which seems like the right thing to do. Maybe there's a reason not to but it seems to fix my problem with no apparent downsides.

Check.sh Issues

Note that I tried running check.sh but it fails to compile 'speech-dispatcher'. Most likely because the version on libspeechd I installed on my machine (latest on Arch linux) is too new and doesn't work with the existing crate.

@emilk
Copy link
Owner

emilk commented Jan 16, 2022

Look good, but needs cargo fmt.

Please file an issue about check.sh and what line in it fails, and with what message!

@juancampa
Copy link
Contributor Author

Look good, but needs cargo fmt.

Please file an issue about check.sh and what line in it fails, and with what message!

Done and done

@emilk emilk merged commit 624e2fc into emilk:master Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants